search

genboy / Festival

Custom events plugin for Pocketmine
https://genboy.net/minecraft/festival/
Other
39 stars 15 forks source link

Crash client drop after ui menu level management #296

Closed genboy closed 3 years ago

genboy commented 4 years ago

A crash occured after level management with the UI menu. same crash when testing v2.1.1 and 2.1.0 - might be pmmp version related or a deprecated packets function in Festival form ui

Error:

2020-07-26 [21:01:22] [Server thread/CRITICAL]: Error: "Undefined property: pocketmine\network\mcpe\protocol\SetSpawnPositionPacket::$spawnForced" (EXCEPTION) in "src/pocketmine/network/mcpe/protocol/DataPacket" at line 205 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #0 plugins/Festival/src/genboy/Festival/FormUI(885): pocketmine\network\mcpe\protocol\DataPacket->set(string[11] spawnForced, boolean 1) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #1 plugins/Festival/src/xenialdan/customui/Form(48): genboy\Festival\FormUI->genboy\Festival{closure}(object pocketmine\Player, array[22]) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #2 src/pocketmine/Player(3600): xenialdan\customui\Form->handleResponse(object pocketmine\Player, array[23]) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #3 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(264): pocketmine\Player->onFormSubmit(integer 6, array[23]) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #4 src/pocketmine/network/mcpe/protocol/ModalFormResponsePacket(49): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleModalFormResponse(object pocketmine\network\mcpe\protocol\ModalFormResponsePacket) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #5 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(110): pocketmine\network\mcpe\protocol\ModalFormResponsePacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #6 src/pocketmine/network/mcpe/protocol/BatchPacket(127): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\ModalFormResponsePacket) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #7 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(110): pocketmine\network\mcpe\protocol\BatchPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #8 src/pocketmine/Player(3247): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #9 src/pocketmine/network/mcpe/RakLibInterface(169): pocketmine\Player->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #10 vendor/pocketmine/raklib/src/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string[19] 83.84.181.236 64083, object raklib\protocol\EncapsulatedPacket, integer 0) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #11 src/pocketmine/network/mcpe/RakLibInterface(109): raklib\server\ServerHandler->handlePacket() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #12 src/pocketmine/network/mcpe/RakLibInterface(99): pocketmine\network\mcpe\RakLibInterface->process() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #13 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe{closure}() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #14 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #15 src/pocketmine/Server(2157): pocketmine\snooze\SleeperHandler->sleepUntil(double 1595797282.4142) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #16 src/pocketmine/Server(1994): pocketmine\Server->tickProcessor() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #17 src/pocketmine/Server(1588): pocketmine\Server->start() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #18 src/pocketmine/PocketMine(273): pocketmine\Server->construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[15] /home/gs-40310/, string[23] /home/gs-40310/plugins/) 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #19 src/pocketmine/PocketMine(304): pocketmine\server() 2020-07-26 [21:01:22] [Server thread/CRITICAL]: #20 (11): require(string[94] phar:///pro/bin/mcpe/pocketmine-stable-1.16.0/PocketMine-MP.phar/src/pocketmine/)

genboy commented 3 years ago

Notes/in progress https://github.com/pmmp/PocketMine-MP/commit/e990c5a0a57a651c5d6a0796d0692a1d6aae868d and https://github.com/pmmp/PocketMine-MP/issues/944

genboy commented 3 years ago

This is the same bug as in #297 and has to do with sending data for the compass while switching to another level or changing the compass direction. The issue is solved in the latest dev update #121, will soon work on a new release.