search

genbtc / AutoTrimps

Automation for the idle incremental game 'Trimps'
36 stars 51 forks source link

Bugs within Auto Breed Timer + possible fixes #145

Open nonodesu opened 6 years ago

nonodesu commented 6 years ago

  1. If you have 'Auto Breed Timer' disabled and then set 'Geneticist Timer' to any value other than -1, 'Geneticist Timer' will be reset to 'undefined'. A possible fix. File 'breedtimer.js' Before: if (newGeneTimerSetting != targetBreed) { After: if (manageBreedTimer && newGeneTimerSetting != targetBreed) {

  2. If 'Geneticist Timer' is set to -1 and you turn on 'Auto Breed Timer', it won't actually do anything. To make it work you'd also need to change 'Geneticist Timer' to a value higher than 0. A possible fix. File 'AutoTrimps2.js' Before: if (getPageSetting('GeneticistTimer') >= 0) autoBreedTimer(); After: if (getPageSetting('ManageBreedtimer') || getPageSetting('GeneticistTimer') >= 0) autoBreedTimer();

Note that I actually didn't test those fixes so I don't know if they actually fix the bugs or break anything, so please test before commiting.

genbtc commented 6 years ago

I fixed the first one. The second one needs more work for now. The whole file needs work, and I am working on switching over mostly to Geneticist Assist and make it work with Auto Breed Timer. If you have any objections to why you dont use geneticist assist already let me know

nonodesu commented 6 years ago

If you have any objections to why you dont use geneticist assist already let me know

Haven't unlocked it yet. ¯\_(ツ)_/¯ It's unlocked at 170 and I am only at 110.

genbtc commented 6 years ago

For anyone else reading this: If you are running to around zone 450: Regarding Geneticist Assist, for the time being you can use Geneticist Assist inconjunction with or without all AutoTrimps settings. The gen assist options Gene Fire with Enforce Gene Send, Using Gene Send or Wait for Gene Send are basically the 4 types of conditions that AT had coverage for in its own code. AT's autoBreedTimer() function was made before GA even existed let alone had all these options, now that they exist in GA, AT can be phased out - except for those players below the level, of which, the current AT system still is more viable than not.

I will continue looking into the concept of geneticists, breeding and the like.

Akenator commented 6 years ago

I tried running purely GA. Works fine for hiring firing. But the gen assist options "Gene Fire with Enforce Gene Send, Using Gene Send or Wait for Gene Send" look tied to the Auto Fight setting which AT turns off. I'm messing around with it a bit more but it looks like you can turn off autobreed timer and just manually set genetisist to 45 sec and let the AT logic go...but i dont see any difference with using the gene settings in the actual game itself doing anything unless i am missing something.