Closed ricardoruwer closed 4 years ago
Hi @ricardoruwer i think i might found the issue.
To make sure i found the right issue source, can you install this and try the following syntax highlighter?
https://marketplace.visualstudio.com/items?itemName=CraigMaslowski.erb
After installing this, if it works then we will handle this in the future.
Thank you for the quick answer ❤️ I installed this new extension, and:
The Emmet doesn't work:
e.g. when I type h1
and press TAB it doesn't create the <h1></h1>
.
But the IntelliSense works :)
e.g. when I type <h1 class=""></h1>
the HTML classes appear in the list...
Actually, I'm not sure... 🤔 Forget what I said...
I think this extension you said makes no difference...
When I change the language mode (CMD+K M
) and type erb
I have 2 options on the list:
In this html.erb
nothing works (emmet and any other autocomplete)
(I don't know if the emmet operation is a responsibility of this extension)
And in this erb
just the class completion works;
e.g. when I type <h1 cla
there is one class
on the list, and when I select it, it completes just with class
but I think it might complete with class=""
, you know?
And when I type e.g. <h1 class="
the class completion works
But apparently this extension you said https://marketplace.visualstudio.com/items?itemName=CraigMaslowski.erb makes no difference to this
Hmm.. Strange. Let me evaluate on a fresh installation.
It'll be nice to add support for Elixir (.html.eex
) files as well 😄
.eex
extension added.
.eex
support has been released on marketplace. You may need an another extension to trigger language specific things.
Thanks for the eex support ! However, the language name seems incorrect, so it doesn't work.
The 2 major language extensions for Elixir uses different language names :
HTML (Eex)
HTML (EEx)
Could you please add HTML (Eex)
and HTML (EEx)
support ? That would made this plugin the first to support this feature for elixir afaik, since all the other ones seems inactive.
Thanks !
I didn't know that one exists. Yes, As soon as i back to home, i will add this support.
P.S.: You will need those extensions as well to work with this extension. They are dependent.
Amazing, thank you for responding so quickly ! 👍 💯
BTW, a quick question while im on remote:
It is HTML E(E|e)x
, right? Not EEx
and Eex
. It has 'HTML
' at start.
Update: Yup. Checked on GitHub it is indeed.
Yes !
Here are the exact names for both cases :
HTML (Eex)
HTML (EEx)
They both contains HTML
and parenthesis.
Okay. I will prepare a custom build as soon as possible -and push to master
-
Please also note that, This will also includes #49 and #50. #49 is about fetching remote stylesheet from meta links in HTML compatible files instead of permanent setting in vscode.
@clementoriol, Please can you try this version: If you downloaded this, re-download again
html-slim-scss-css-class-completion-1.7.0.zip
I didn't tested yet so i await your feedback
@gencer Ok, so I had time to test this !
Tested both with vscode-elixir
and ElixirLs
extensions.
vscode-elixir
(lang set to HTML (Eex)
)ElixirLS
(lang set to HTML (EEx)
) Did you had the chance to add both languages ? I know the case difference is a bit annoying, but sadly the libraries haven't done anything yet to harmonize it, afaik
Interesting. See, I already added EEx and Eex (lowercase and uppercase). I will try to find out why it didn't worked.
Nevermind, it actually works, I guess it just took some time to index the scss :) So, looks good to me, thank you 🎉🎉🎉
Ahh :=) No worries! If your project is big, it might take some time to warm up on first time. Later, it will incrementally build and re-cache.
Changes are on master
. I will publish v1.7.0
on marketplace soon.
@clementoriol I found the issue. Fixed in master will be published in few minutes on marketplace. Please test v1.7.1 for EEx (uppercase E)
I couldn't make it work in
.html.erb
files!When I'm editing a pure HTML file:
But when I change to
.html.erb
:I'm currently using the Ruby extension https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby