gencer / SCSS-Everywhere

A Visual Studio Code extension that provides CSS class and ID atttribute completion with incremental build and usage explorer for the HTML class attribute based on the CSS/Template files in your workspace. Also supports React's className attribute.
https://marketplace.visualstudio.com/items?itemName=gencer.html-slim-scss-css-class-completion
MIT License
24 stars 9 forks source link

Stopped working in 1.7.1 #51

Closed garyking closed 4 years ago

garyking commented 4 years ago

I downgraded back to 1.5.23 since this extension stopped working in 1.7.1, released yesterday.

With the new version, the lightning icon doesn't appear in the status bar; when opening a workspace, the "cached stylesheets" message DOES briefly appear, though.

I also disabled all other extensions to test.

My settings:

"html-css-class-completion.remoteStyleSheets": [
      "https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/4.4.1/css/bootstrap.css",
      "https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.12.1/css/all.min.css"
    ]
gencer commented 4 years ago

Do you have any logs in Developer Tools (Console)?

It will help me to debug as fast as possible.

garyking commented 4 years ago

I updated the original post for more accurate information

I've attached screenshots from Toggle Developer Tools.

Latest version (the one that isn't working):

Latest version

Latest working version:

Latest working version

gencer commented 4 years ago

@garyking Just trying something from my end. Does this solve your problem?

v1.7.2

html-slim-scss-css-class-completion-1.7.2.zip

akmeghdad commented 4 years ago

Hello,

Yes sir, v1.7.2 (html-slim-scss-css-class-completion-1.7.2.zip) solved my problem.

Thank you

IgorKrupenja commented 4 years ago

I think I was also getting this with 1.7.1. In my case, the extension was repeatedly crashing ExtensionHost and none of the other extensions were usable - disabling SCSS Everywhere resolved this. With 1.7.2 and SCSS Everywhere enabled, I do not see this problem anymore 👍

gencer commented 4 years ago

@akmeghdad @krupenja @garyking

Sorry for the trouble. Glad it did worked. I just published v1.7.2 on marketplace. Also changes are in master

Thank you for confirming guys! I really appreciated it.

One more time, sorry for the trouble I made with last release.

gencer commented 4 years ago

Closing this issue. Please let me know if something is not right again.

garyking commented 4 years ago

I'm sorry, but it's still not working for me. I currently have this extension SCSS Everywhere 1.7.2 installed, the latest. All other extensions disabled. I open a workspace with remote stylesheets, with the settings mentioned here.

On workspace startup, I see the "Looking for CSS stylesheets" message briefly (about 0.1 seconds). In a React file, in the className attribute, I try typing a class name from Bootstrap. But no class suggestions appear, from this extension.

Downgrading to the 1.5.23, once again, fixes the problem for me. Also, the "Looking for" message remains for much longer (about 5 seconds). Perhaps this is an issue with the new version not able to find remote stylesheets?

gencer commented 4 years ago

@garyking Do you use searchRemoteGlobPattern or just remote stylesheet as mentioned by you earlier?

gencer commented 4 years ago

v1.7.4-2

Intensive debug information added.

Please try this version. This will enable debug logging which tagged as SCSS-EVERYWHERE-DEBUG. It will help me to understand where it get stuck.

html-slim-scss-css-class-completion-1.7.4.zip

garyking commented 4 years ago

I don't use the searchRemoteGlobPattern setting. It only exists in the 1.7 version, but I'm using the 1.5 version.


I installed the v1.7.4-2 version. The problem is fixed in that version. I've also attached the logs, anyway.

Screen Shot 2020-04-27 at 3 04 30 pm

gencer commented 4 years ago

Glad it did worked. This is really a weird situation.

Hopefully will not break again. Will publish on marketplace now.

Thanks! Let me know if help needed again. Can I close issue now? If everything is ok?

-- And sorry for such trouble!

garyking commented 4 years ago

Yeah problem is fixed in 1.7.4, which I currently have installed.

Is it necessary to leave the debug messages in the extension?

gencer commented 4 years ago

Not necessarily. I will remove those debug messages in next version ;)

I just want to make sure nobody has the same issue again. So, will be removed in next.