search

genderkit / genderkit

Gender Construction Kit - The UK guide to changing things linked to gender
http://www.genderkit.org.uk
Other
67 stars 15 forks source link

Check we're ticking all the boxes on the Front End Checklist #49

Open fallax opened 7 years ago

fallax commented 7 years ago

https://github.com/thedaviddias/Front-End-Checklist

jlphackett commented 3 years ago

I ran through the relevant items for this:

Green
- Apple Web App Meta not all set up
- Alternate language and international landing pages not set
- No RSS link
- some Twitter card stuff not set

Orange
- html direction not set
- critical path CSS not inlined
- external links should have rel="noopener" set
- no print stylesheet
- no HTML sitemap

Red
- our version of normalize.css is several major versions out of date
- missing some vendor prefixes; should we set up an autoprefixer?
- CSS files should be concatenated
- padding-block-end is not a real property!

Accessibility Alerts
- All pages should have an H1 that is not the title of the website
  - In general, our H3s should be H2s and our H2s should be H1s
- Our bib links should say more than just "Link", or maybe turn the whole entry into a link
- We should state when we're linking to a PDF

W3C validator warnings:
- some unnecessary roles:
  - header does not need the banner role
  - main does not need the main role
- article lacks heading (I think this is because we wrap the whole thing in a section, which isn't ideal from a semantic perspective)

HTML Linter warnings:
- compatibility
  - theme-color meta not widely supported
  - content-types should specify character set
- pwa
  - apple-touch-icon should not have a "sizes" attribute
  - apple-touch-icon-precomoposed is redundant
  - web app manifest should have filename extension ".manifest"
- performance
  - cache control max age for web pages too high (should be <= 180)
  - cache control max age for resources too low (should be >= 31536000)
  - "Resource should use cache busting but URL does not match configured patterns." not sure what this means
  - static resources should be treated as immutable
- security
  - "via" header should not be used
  - "expires" header should not be used
  - "strict-transport-security" header not specified
  - no "x-content-type-options" header for resource

I think the most important things here are the W3C validator warnings, "red" things and accessibility things; the rest can probably be low priority?