search

genebean / PiWeatherRock

Displays local weather on a Raspberry Pi
https://piweatherrock.technicalissues.us
MIT License
50 stars 23 forks source link

Start stop #54

Closed metaMMA closed 4 years ago

metaMMA commented 4 years ago

NOTE: This PR is branched from logging PR. It's here for debugging purposes. I will create a new PR with these changes, once logging PR is merged.

metaMMA commented 4 years ago

Not sure if the refs to MY_DISP will cause any issues on lines 118 and 122

def get_windspeed_abbreviation(unit=MY_DISP.config["units"]):
    return get_abbreviation(units_decoder(unit)['windSpeed'])

def get_temperature_letter(unit=MY_DISP.config["units"]):
genebean commented 4 years ago

You should be good to rebase now.

genebean commented 4 years ago

As part of this, what do you think of removing the restart always from the PiWeatherRock unit file?

metaMMA commented 4 years ago

As part of this, what do you think of removing the restart always from the PiWeatherRock unit file?

I'm leaning toward leaving it in there. I think most exceptions are being caught, but in the case that something unforeseen does happen, maybe it's a good thing to automatically retry?

I was thinking it might be a good idea to change to keybinding of q to mimic the way the start/stop slider works: change the lock file to 0. What do you think?