search

genebean / genebean-nxlog

A Puppet module to manage NXLog
BSD 3-Clause "New" or "Revised" License
5 stars 16 forks source link

Add input_options #13

Closed yachub closed 5 years ago

yachub commented 5 years ago

Please see changes in the PR to add input_options parameter in order to specify additional directives for the input. For example, we need to be able to set the parameter input_options => [ 'SavePos TRUE', ], in an nxlog::config::input defined type.

Also, I encountered nxlog errors that caused the service not to start due to the single quotes included with the value of InputType. For example, the InputType for the Input we were using had to be InputType LineBased instead of InputType 'LineBased'.

What do you think of these changes?

I tried fixing the unrelated failures LoadError: cannot load such file -- win32ole, but no luck. Any idea?

Thanks,

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling 59a1dbf9223f936856c259810c9f44c532716d5a on feature/add_input_options into 3195419809c1d92ba6587f03ccab021c874cdbba on develop.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at ?% when pulling 3ff2d31f21b854086b4481735715db36386f0a68 on feature/add_input_options into 1d3b530e51b78166582d8bb3c3042b16403d00ec on develop.

genebean commented 5 years ago

taking a look...

genebean commented 5 years ago

@thespain I think part of the problem is its been 3 years since tests passed... https://travis-ci.org/genebean/genebean-nxlog/builds/158890459 was the last one. I think some of our test code may just be that dated. I am taking a stab at updating it now.

genebean commented 5 years ago

I rebased you on #14