genebean / genebean-nxlog

A Puppet module to manage NXLog
BSD 3-Clause "New" or "Revised" License
5 stars 16 forks source link

Fix line endings for Linux #22

Closed yachub closed 3 years ago

yachub commented 3 years ago

This addresses a change in the last release that always converted templates to windows line ending, but will now convert to correct line ending based on kernel fact (including appropriate tests).

What do you think?

puppet-community-rangefinder[bot] commented 3 years ago

nxlog::config is a class

that may have no external impact to Forge modules.

nxlog::config::extension is a type

that may have no external impact to Forge modules.

nxlog::config::input is a type

that may have no external impact to Forge modules.

nxlog::config::output is a type

that may have no external impact to Forge modules.

nxlog::config::processor is a type

that may have no external impact to Forge modules.

nxlog::config::route is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling b856b83430ed033915f64db1d0f7e60da160bdb0 on fix-line-endings into a8336bf1281a4cfcf1b96298cdf2854bdc7ef8cf on master.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling cd9a16f0ced768bd68924fce15bbc213a48cb3dc on fix-line-endings into a8336bf1281a4cfcf1b96298cdf2854bdc7ef8cf on master.

genebean commented 3 years ago

@yachub any idea why we haven’t merged this already?

yachub commented 3 years ago

@genebean Oops it seems this fell through the cracks, I don't see any reason this can't be merged!