genecommerce / module-encryption-key-manager

Tooling to help generate and invalidate magento encryption keys
GNU Lesser General Public License v3.0
54 stars 14 forks source link

Add admin_user and admin_adobe_ims_webapi to the list of tables that contain encrypted values #11

Closed TuVanDev closed 2 months ago

TuVanDev commented 2 months ago
convenient commented 2 months ago

Hey @TuVanDev

I appreciate the efforts you're going to here, i hope you forgive me if I ask for just a wee tweak.

While you were doing this I also raised #10 and merged it. As part of that process I am also trying to keep a list of full commands to run in the README.md of tables and the targeted field.

See https://github.com/genecommerce/module-encryption-key-manager/blob/58ce868669242af7a9ff5c5c0bca1739fb4f70e2/README.md?plain=1#L49 where I have added

Do you think it would be possible for you to sync with master, and add the example commands for these tables there? That way we have a record of table and column?

TuVanDev commented 2 months ago

Hey Luke, no problem. I'd like to say a huge thank you to you and your team for the effort.

I don't have access to the Yotpo module that contains the yotpo_sync_queue table. Could you take care of this part?

convenient commented 2 months ago

Hey

Ahh no worries 🙂 This kind of tooling and process needed to happen so we figured it was best to just crack on and get started with it, particularly about mitigating the current JWT vector and then following up with the full invalidation process.

I'll merge this and fix up the yotpo one shortly.

If you have any other insights or suggestions I'm all ears, cheers