search

genecommerce / module-encryption-key-manager

Tooling to help generate and invalidate magento encryption keys
GNU Lesser General Public License v3.0
54 stars 14 forks source link

Removed setup_version from module.xml for zero downtime deploy. #13

Closed davekleijn closed 1 month ago

davekleijn commented 2 months ago

This change will allow zero downtime deployments.

convenient commented 2 months ago

This was a silly mistake on my part. Can you think of any problems with removing this for people who already have the module deployed?

davekleijn commented 2 months ago

Hi @convenient,

No problem at all. I am very happy with all the effort you have made.

The only thing I can think of is that Gene_EncryptionKeyManager is added to setup_module table in the database. But this should not be a problem. It is only for backwards compatibility.

If a setup script is added later in time (with version 0.1.0) the script is not running again. But still this is a old way of doing things. Data patches can be used.

davekleijn commented 2 months ago

Furthermore, I don't think that users with a very old Magento version use this module, because they first have to update their Magento before they can even install the latest patch of Magento.

davekleijn commented 2 months ago

Looks like Magento removed them in 2018 already. (https://github.com/magento/magento2/commit/7120e062be824549b8f7b07a611c15fbca64484f)

So as of Magento 2.3.0 it's not required anymore. Therefore this module is not backwards compatible before Magento 2.3.0 when adding this PR.

convenient commented 2 months ago

Thanks @davekleijn , I'll merge and tag when I'm at a computer soon