search

genecommerce / module-encryption-key-manager

Tooling to help generate and invalidate magento encryption keys
GNU Lesser General Public License v3.0
54 stars 14 forks source link

feat: Add ability to specify the encryption key to use in 'generate' … #24

Closed bruno-blackbird closed 1 month ago

bruno-blackbird commented 1 month ago

Hello,

I added an option to specify the key to use in the generate command, it is useful to set the same key in multiple environments.

PS: Thank you so much for your great work @convenient !

convenient commented 1 month ago

Also @bruno-blackbird if you could update https://github.com/genecommerce/module-encryption-key-manager?tab=readme-ov-file#binmagento-geneencryption-key-managergenerate with notes on this new flag please?

bruno-blackbird commented 1 month ago

@convenient Thanks for your feedbacks, I applied all of your suggestions.

convenient commented 1 month ago

@bruno-blackbird That last test run came through like

Generating a new encryption key
A new key will be generated for re-encryption, use "--key" to specify a custom key.
The system currently has 1 keys
Generating a new encryption key using the magento core class
_reEncryptSystemConfigurationValues - start
_reEncryptSystemConfigurationValues - end
_reEncryptCreditCardNumbers - start
_reEncryptCreditCardNumbers - end
Cleaning cache
Done
PASS

Thanks for your contribution 🎉