genecommerce / module-encryption-key-manager

Tooling to help generate and invalidate magento encryption keys
GNU Lesser General Public License v3.0
54 stars 14 forks source link

Add `--skip-saved-credit-cards` to `generate` #26

Closed convenient closed 1 month ago

convenient commented 1 month ago

From @braders in https://github.com/genecommerce/module-encryption-key-manager/issues/9#issuecomment-2243013706

I am working on a site with around 2.5 million records in the sales_order_payment table, and am wary to try loading that into memory.

We don't support saved card numbers, and so cc_number_enc is always empty. It'd be nice to have the possibility to skip running the _reEncryptCreditCardNumbers function.

braders commented 1 month ago

Amazingly quick work. Looks good to me.

convenient commented 1 month ago

Thats tagged now @braders https://github.com/genecommerce/module-encryption-key-manager/releases/tag/v0.0.9-alpha