genecommerce / module-encryption-key-manager

Tooling to help generate and invalidate magento encryption keys
GNU Lesser General Public License v3.0
54 stars 14 forks source link

[IMP] Gene_EncryptionKeyManager: Add support for JSON fields #27

Closed tedsalmon closed 1 month ago

tedsalmon commented 1 month ago
convenient commented 1 month ago

Hello @tedsalmon

Well this is something I didn't anticipate. Am I correct in remembering that column names in mysql are not allowed to have a . in them? That means this should be safe?

So that I can capture a test case could you please provide me an example JSON payload? The tests for this module are very rough and ready so I'm happy to craft that myself if you can get me started

tedsalmon commented 1 month ago

Hi @convenient !

Well this is something I didn't anticipate. Am I correct in remembering that column names in mysql are not allowed to have a . in them? That means this should be safe?

Yeah, dots are a SQL delimiter character, thus they are not valid in schema, table or column names.

So that I can capture a test case could you please provide me an example JSON payload? The tests for this module are very rough and ready so I'm happy to craft that myself if you can get me started

Here you go:

 {
     "behavior": "append",
     "import_source": "file",
     "user": "",
     "password": "0:3:RV6\/qFFHn1zU2QmpFA9cysL5fdxS17T34LeY0jwx27u\/SiTtgVmOzw==",
     "username": "0:3:r+6nYk642juvyu7+YGUl0mNmA3qbApenyl\/STX7XTh7\/SHNYzA==",
     "soap_version": "SOAP_1_1",
     "request_url": "",
 }

Thanks! -Ted

convenient commented 1 month ago

Thank you for your contribution