search

genelkim / ulf2english

Maps EL-ULFs to English sentences.
MIT License
1 stars 0 forks source link

Be.v not conjugated when following argument is *h #27

Closed genelkim closed 5 years ago

genelkim commented 5 years ago
Expected "I know in how deep a financial hole he now is because of his risky investments" but saw "I knows in how deep a financial hole he now be because of his risky investments" EXPECTED => "I know in how deep a financial hole he now is because of his risky investments" GENERATED => "I knows in how deep a financial hole he now be because of his risky investments" ULF => (I.PRO ((PRES KNOW.V) (ANS-TO (SUB (IN.P (SUB (HOW.ADV-A DEEP.A) (A.D (H (FINANCIAL.A HOLE.N))))) (HE.PRO NOW.ADV-E ((PRES BE.V) H) (ADV-S (BECAUSE_OF.P (HIS.D (RISKY.A (PLUR INVESTMENT.N))))))))))
Failed Form: GENERATED
Expected "How curious they are" but saw "How curious they be"
EXPECTED => "How curious they are"
GENERATED => "How curious they be"
ULF => (SUB (HOW-EM.ADV-A CURIOUS.A) (THEY.PRO ((PRES BE.V) *H)))
Failed Form: GENERATED
Expected "How studious he is" but saw "How studious he be"
EXPECTED => "How studious he is"
GENERATED => "How studious he be"
ULF => (SUB (HOW-EM.ADV-A STUDIOUS.A) (HE.PRO ((PRES BE.V) *H)))
genelkim commented 5 years ago

Some of this was actually because the ULF weren't properly updated -- adv-a -> mod-a

genelkim commented 5 years ago

We needed a prepositional phrase type separate from a simple preposition type since simple prepositions require two arguments whereas a prepositional phrase only takes one. A PP type didn't exist before since Englsih doesn't really have single word PPs, but we need it for marking *h with the type in the intermediate analyses.

This was fixed in ulf-lib commit: https://github.com/genelkim/ulf-lib/commit/3ae0434d5fec64ee10ce780c132db91481bd6578