search

genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Set MAF default based on # samples #346

Closed zsloan closed 5 years ago

zsloan commented 6 years ago

Abe mentioned during the presentation that it might be a good idea to make the MAF 0.01 for situations with ~1000 samples. This is a pretty easy change to make, so I'll ask Rob about it.

robwwilliams commented 6 years ago

Sure. Default could be a function of n of traits with data.

On Mon, Nov 5, 2018 at 10:20 PM zsloan notifications@github.com wrote:

Abe mentioned during the presentation that it might be a good idea to make the MAF 0.01 for situations with ~1000 samples. This is a pretty easy change to make, so I'll ask Rob about it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/issues/346, or mute the thread https://github.com/notifications/unsubscribe-auth/ALva_M-c1lo2UhMdi486BB-E4kTnKZ_-ks5usJ2TgaJpZM4YPMGk .

-- Rob

Robert W. Williams, Ph.D. Chair: Department of Genetics, Genomics and Informatics 71 S Manassas St, Memphis TN 38163 University of Tennessee Health Science Center Office 901 448-7050 CELL 901 604 4752 Office: Translational Science Research Building, Room 407 EMAIL: rwilliams@uthsc.edu Alternative email: labwilliams@gmail.com SKYPE: robwwilliams

zsloan commented 5 years ago

This change was made a while back, though the logic can still be made more complex if someone can decide upon a good formula to use (currently it just sets it to 0.01 for N>500 and 0.05 otherwise, but I don't want to make it more specific unless someone else signs off on it).

Anyways, closing this since the change mentioned in the issue was already made.