genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Chore(javascript/css): Remove google CDNs and analytics #396

Closed BonfaceKilz closed 4 years ago

BonfaceKilz commented 4 years ago

Description

Doing grep -r google gets:

Click to see output
Binary file webtests/chromedriver matches
wqflask/wqflask/templates/new_security/login_user.html:    
wqflask/wqflask/templates/new_security/verification_still_needed.html:    
wqflask/wqflask/templates/new_security/forgot_password.html:    
wqflask/wqflask/templates/new_security/password_reset.html:    
wqflask/wqflask/templates/new_security/forgot_password_step2.html:    
wqflask/wqflask/templates/new_security/register_user.html:    
wqflask/wqflask/templates/new_security/registered.html:    
wqflask/wqflask/templates/new_security/thank_you.html:    
wqflask/wqflask/templates/base.html:    
wqflask/wqflask/templates/base.html:    
wqflask/wqflask/templates/loading.html:
wqflask/wqflask/templates/reference.html: Google Scholar search for   "genenetwork" OR "webqtl"   generated:
wqflask/wqflask/templates/reference.html:Google Scholar search for   "genenetwork.org"  generated:
wqflask/wqflask/templates/reference.html:Full Text HTML Version
wqflask/wqflask/templates/reference.html:Benhamou JP, Rizzetto M, Reichen J, Rodés J (2007) Textbook of hepatology: from basic science to clinical practice. Blackwell Publishing, p. 379), ISBN 1405127414
wqflask/wqflask/templates/reference.html:95-114), ISBN 1405127414
wqflask/wqflask/templates/reference.html:Fox JG, Barthold SW, Davisson MT, Newcomer CE (2007) The mouse in biomedical research. (2nd ed). Academic Press,  p. 530.
wqflask/wqflask/templates/reference.html:Hsu HC, Lu L, Yi N, Van Zant G, Williams RW, Mountz JD (2007) Quantitative trait locus mapping in aging systems. In: Methods in Molecular Biology (Vol 371). Biological Aging: Methods and Protocols, ed Tollefsbol TO, Humana Press, Inc., Netlibrary, Springer   
wqflask/wqflask/templates/reference.html:Google Book Search
wqflask/wqflask/templates/reference.html:Jones BC and Mormede JP (2007) Neurobehavioral genetics: methods and applications. (2007)" CRC Press, Taylor & Francis Group, Boca Raton, Florida, p. 102, ISBN 084931903X
wqflask/wqflask/static/new/js_external/chroma.js:      http://code.google.com/p/figue/source/browse/trunk/figue.js#336
wqflask/wqflask/static/packages/pragmaticly-smart-time-ago-40fa376/test/lib/jquery.js:          // http://code.google.com/p/v8/issues/detail?id=1050
wqflask/wqflask/static/packages/colorbox/README.md:  Example: $('a[href='http://msn.com']).colorbox({'href':'http://google.com', iframe:true});
wqflask/wqflask/static/packages/colorbox/example3/index.html:       
wqflask/wqflask/static/packages/colorbox/example1/index.html:       
wqflask/wqflask/static/packages/colorbox/example5/index.html:       
wqflask/wqflask/static/packages/colorbox/example2/index.html:       
wqflask/wqflask/static/packages/colorbox/example4/index.html:       

and doing curl http://gn2.genenetwork.org/ | grep google gets:

Click to see output
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 31823  100 31823    0     0  23891      0  0:00:01  0:00:01 --:--:-- 23891
    
    

We need to remove the jquery version, and package them in guix and use the ones from there.

pjotrp commented 4 years ago

Yes!