genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Fix issues that prevented genotype traits from being added to collect… #692

Closed zsloan closed 2 years ago

zsloan commented 2 years ago

There were some errors when adding genotypes to a collection.

Most were related to the "trait_info_str" function in collect.py - I think that this was just written while overlooking genotype traits (which is understandable, since they're usually not used when testing). To get things working again I had it set some default values of "N/A" or 0, just to prevent the error. Ideally this function probably shouldn't be necessary, since there's many other functions that involve passing around lists of traits and do so in the same way (which can be improved if necessary, but they should all be using the same code).