Chore/GN2 Clean up - Githubissues

genenetwork / genenetwork2

GeneNetwork (2nd generation)

http://gn2.genenetwork.org/

GNU Affero General Public License v3.0

34 stars 24 forks source link

Chore/GN2 Clean up #715

Closed BonfaceKilz closed 2 years ago

BonfaceKilz commented 2 years ago

Description

This PR:

Removes FlaskDebugToolbar. It's utility is already provided natively in Python's pudb module. @fredmanglis @Alexanderlacuna and @zsloan take note. Eventually, I'll remove this as an input in gn2's definition in our channel.
Uses new function signature when fetching case-attributes.
Fix edge-case when listing diffs if a user who edits a file does not exist in Redis. This should never happen, but nevertheless, I catered for it.

zsloan commented 2 years ago

Good idea with addressing the edge case of a user not existing in Redis. Issues similar to this popped up in the past (due to a mistake in the code, but still - users who created their accounts at different times sometimes didn't have certain attributes, or had multiple accounts for the same e-mail address).