search

genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Decompose file into separate modules #735

Closed fredmanglis closed 1 year ago

fredmanglis commented 1 year ago

To ease future refactors on the code, decompose the file into a module with multiple modules that can be refactored semi-independently.

Description

This commit splits out the various classes and functions in wqflask/base/dataset.py into a package wqflask/base/dataset with multiple modules.

Any background context you want to provide?

https://issues.genenetwork.org/issues/simplify_data_set_py_in_gn2

What are the relevant pivotal tracker stories?

https://issues.genenetwork.org/issues/simplify_data_set_py_in_gn2

zsloan commented 1 year ago

Should this only require changing the way dataset is imported? It seems so from what I can tell.

fredmanglis commented 1 year ago

@zsloan actually, not really. Everything should work as is.

fredmanglis commented 1 year ago

@zsloan For most part, you should be able to import everything with:

from base.data_set import ...

if you look at /wqflask/base/init.py I imported all the classes and functions from the modules in the new base.data_set package