search

genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Feature/add trait columns #748

Open zsloan opened 1 year ago

zsloan commented 1 year ago

This PR adds the option to add traits from a collection as extra pseudo-"case attribute" columns on the trait page.

The user can then filter off of those columns just like off of normal case attribute columns

robwwilliams commented 1 year ago

Very cool. Excited to test. Thanks.

On Thu, Nov 17, 2022 at 3:57 PM zsloan @.***> wrote:

This PR adds the option to add traits from a collection as extra pseudo-"case attribute" columns on the trait page.

The user can then filter off of those columns just like off of normal case attribute columns

You can view, comment on, or merge this pull request online at:

https://github.com/genenetwork/genenetwork2/pull/748 Commit Summary

File Changes

(5 files https://github.com/genenetwork/genenetwork2/pull/748/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/pull/748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC55V7HJLBVUGYHOYGQYAGLWI2S3XANCNFSM6AAAAAASD3B3NU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Rob

Robert W Williams PhD Department of Genetics, Genomics and Informatics 71 S Manassas St, Memphis TN 38163 University of Tennessee Health Science Center, TSRB 405 Cell: 901 604 4752 EMAIL: @.*** Zoom: https://tennesseehipaa.zoom.us/j/9492269658

zsloan commented 1 year ago

It isn't on production yet, but it is on my branch right now.

The option to remove added columns doesn't exist yet (and when I do add it, it'll probably just be the option to remove all added columns, since doing it for specific ones will greatly complicate things), but the transform functions should work.

One complication (that shouldn't be hard to address, but need to decide how) is the existence of x values. Currently it just completely ignores all samples like that. Probably easier to just show what I'm talking about, so I'll do that tomorrow morning.

On Thu, Nov 17, 2022, 4:12 PM Rob Williams @.***> wrote:

Very cool. Excited to test. Thanks.

On Thu, Nov 17, 2022 at 3:57 PM zsloan @.***> wrote:

This PR adds the option to add traits from a collection as extra pseudo-"case attribute" columns on the trait page.

The user can then filter off of those columns just like off of normal case attribute columns

You can view, comment on, or merge this pull request online at:

https://github.com/genenetwork/genenetwork2/pull/748 Commit Summary

Create button for adding traits to table

Destroy/empty table before creation

Add JS for adding traits to table

Only empty table container on loading if data is loaded from JSON

Make Transform/Filter options work with added trait columns

File Changes

(5 files https://github.com/genenetwork/genenetwork2/pull/748/files)

(300)

(5)

(331)

(11)

(2)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/pull/748, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AC55V7HJLBVUGYHOYGQYAGLWI2S3XANCNFSM6AAAAAASD3B3NU

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Rob

Robert W Williams PhD Department of Genetics, Genomics and Informatics 71 S Manassas St, Memphis TN 38163 University of Tennessee Health Science Center, TSRB 405 Cell: 901 604 4752 EMAIL: @.*** Zoom: https://tennesseehipaa.zoom.us/j/9492269658

— Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/pull/748#issuecomment-1319275903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANQJGCMMZD2VWMCO7PHCITWI2UWRANCNFSM6AAAAAASD3B3NU . You are receiving this because you were assigned.Message ID: @.***>