Closed zsloan closed 1 year ago
BonfaceKilz
commented
1 year ago I'll have a look at this later today. Thanks!
-- (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org))
zsloan
commented
1 year ago I'll have a look at this later today. Thanks! … -- (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org))
It's not finished yet so no rush (though I might end up finishing it later tomorrow if it ends up being as straight-forward as I'm hoping it will be).
BonfaceKilz
commented
1 year ago zsloan @.***> aliandika:
I'll have a look at this later today. Thanks! … -- (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org))
It's not finished yet so no rush (though I might end up finishing it later tomorrow if it ends up being as straight-forward as I'm hoping it will be).
Sure!
-- (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org))
BonfaceKilz
commented
1 year ago zsloan @.***> aliandika:
I'll have a look at this later today. Thanks! … -- (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org))
It's not finished yet so no rush (though I might end up finishing it later tomorrow if it ends up being as straight-forward as I'm hoping it will be).
Sure! -- (Life is like a pencil that will surely run out, but will leave the beautiful writing of life.) (D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.openpgp.org))
zsloan
commented
1 year ago Should have marked this as ready a while ago, since it seems to have been working fine when Rob's been using it from my branch.
robwwilliams
commented
1 year ago Thanks Zach.
On Sat, Feb 11, 2023 at 19:33 zsloan @.***> wrote:
Should have marked this as ready a while ago, since it seems to have been working fine when Rob's been using it from my branch.
— Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/pull/763#issuecomment-1426916508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC55V7HVZ5JIJK572CYQWMTWXA4XXANCNFSM6AAAAAAUAZNZMU . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- Rob
This PR will add the option to get a shareable link for mapping results.
The way I'm planning on doing this will rely on the caching of the actual mapping tools themselves. While I would like to avoid re-running all the code for actually drawing the figure (etc), it isn't really practical due to how much of a mess the mapping display code is. The simplest way to do this seems to be to store the options as they exist at the beginning of run_mapping.py, because at that point the options can be JSON serialized. In display_mapping_results.py the options are no longer JSON serializable, so I'm not sure how to store them at that point without having to add a bunch of extra code that allows the dataset to be passed as either a string or object, etc.