robwwilliams
commented
1 year ago Dear Zach,
Thanks a ton.
On Fri, Apr 28, 2023 at 1:35 PM zsloan @.***> wrote:
This PR allows edited sample data to be used in scatterplots linked from the correlation and mapping results pages.
It works by storing the edited sample data as JSON in Redis and passing the key to the scatterplot page. The page can still be used without the dataid, but it'll use the default values for the traits in question.
You can view, comment on, or merge this pull request online at:
https://github.com/genenetwork/genenetwork2/pull/779 Commit Summary
- f03198f https://github.com/genenetwork/genenetwork2/pull/779/commits/f03198fcc6df61df53ff2a6f5d07e6689ad67894 Cache trait sample data for mapping
- 782889e https://github.com/genenetwork/genenetwork2/pull/779/commits/782889eb47cb501d1c1601d48d89059bee6693ab Use cached sample data in scatter plots (when applicable)
- 522e1d7 https://github.com/genenetwork/genenetwork2/pull/779/commits/522e1d74f0a23baadc48b9dc733247dbd7dcc719 Enable passing dataid for correlation results
File Changes
(7 files https://github.com/genenetwork/genenetwork2/pull/779/files)
- M wqflask/wqflask/correlation/corr_scatter_plot.py https://github.com/genenetwork/genenetwork2/pull/779/files#diff-ebfa887775c57523b27e9cf53106857951843089855e35489dc44a9b40d5aea7 (21)
- M wqflask/wqflask/correlation/show_corr_results.py https://github.com/genenetwork/genenetwork2/pull/779/files#diff-3fdb436383cbd7c94e40080d2b8e1cf407332baf94349576ade6306ea97f129c (10)
- M wqflask/wqflask/marker_regression/display_mapping_results.py https://github.com/genenetwork/genenetwork2/pull/779/files#diff-0d8d5742139cda778e099811654363b2d299d791adde22fbefebf0ff6a4ba848 (1)
- M wqflask/wqflask/marker_regression/run_mapping.py https://github.com/genenetwork/genenetwork2/pull/779/files#diff-f7722ccd379ee0b62b90c595dd14a8d32193e7214b50426dd2838f83f26172d0 (1)
- M wqflask/wqflask/templates/correlation_page.html https://github.com/genenetwork/genenetwork2/pull/779/files#diff-8e43a47f4db19817fb7ad62665dc2bf01330902bc58cb125b722da33647b02a0 (2)
- M wqflask/wqflask/templates/mapping_results.html https://github.com/genenetwork/genenetwork2/pull/779/files#diff-05de44c4d4ed2ab16c219dbbfa8e2dd71914016d13607b3fb048eb318b0d8b31 (2)
- M wqflask/wqflask/views.py https://github.com/genenetwork/genenetwork2/pull/779/files#diff-b60a8a8d69a8d96c5db54a36d02ebe6e9250e0c4121404ae707fb404d8405be3 (10)
Patch Links:
- https://github.com/genenetwork/genenetwork2/pull/779.patch
- https://github.com/genenetwork/genenetwork2/pull/779.diff
— Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/pull/779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC55V7FJZH6ODGAPQQGT2I3XDQEWFANCNFSM6AAAAAAXPSLC5M . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- Rob
This PR allows edited sample data to be used in scatterplots linked from the correlation and mapping results pages.
It works by storing the edited sample data as JSON in Redis and passing the key to the scatterplot page. The page can still be used without the dataid, but it'll use the default values for the traits in question.