search

genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Decouple database connection from environment #795

Closed fredmanglis closed 1 year ago

fredmanglis commented 1 year ago

Description

Commit f259a48c659b6e81ad51ca3d50128737199024c3 decouples the database_connection(...) function from the application and its environment by adding an argument allowing the passing of the database URI as an argument.

Commit 1b8b659312059fc184f96b2708104fdaf0dc812b updates all the calls to database_connection(...) throughout the application.

zsloan commented 1 year ago

I'm the process of looking at this right now, though it seems fine so far (and the nature of the changes seem like any potential issues would pop up pretty quickly, since it's a change to how it calls the database_connection).