genenetwork / genenetwork2

GeneNetwork (2nd generation)
http://gn2.genenetwork.org/
GNU Affero General Public License v3.0
34 stars 24 forks source link

Incorrect documentation will lead to scrambled trait submission. #839

Open rupertoverall opened 3 months ago

rupertoverall commented 3 months ago

Trait submission for GN2 (via https://genenetwork.org/submit_trait) links to a page of example formats (https://gn1.genenetwork.org/RIsample.html). The information on this page is incorrect and will result in scrambled trait data being uploaded. Specifically, the order of the strains (for BXD at least) as quoted is not the order used by GN. This is easy to test by simply uploding the example trait and observing that the value for C57BL/6 has changed from missing ('X') to 6.717.

zsloan commented 3 months ago

Ah, I'll see if I can update this for BXD at least; those pages are just really out of date. At some point we need to just move them to GN2.

On Wed, Apr 10, 2024, 8:59 AM Rupert Overall @.***> wrote:

Trait submission for GN2 (via https://genenetwork.org/submit_trait) links to a page of example formats (https://gn1.genenetwork.org/RIsample.html). The information on this page is incorrect and will result in scrambled trait data being uploaded. Specifically, the order of the strains (for BXD at least) as quoted is not the order used by GN. This is easy to test by simply uploding the example trait and observing that the value for C57BL/6 has changed from missing ('X') to 6.717.

— Reply to this email directly, view it on GitHub https://github.com/genenetwork/genenetwork2/issues/839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANQJGFDJDVWOJXLVM42NB3Y4VASTAVCNFSM6AAAAABGAQH2UWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTKNRXGYYTANA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

rupertoverall commented 3 months ago

The correct order is easy to get: just pull down any random trait from the desired cross - so perhaps the examples page is not even needed (it may also be not so hard to dynamically generate).