geneontology / amigo

AmiGO is the public interface for the Gene Ontology.
http://amigo.geneontology.org
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

XSS vulnerability in Gannet #576

Closed kltm closed 3 years ago

kltm commented 5 years ago

It is currently possible to inject disrupting code into Gannet parameters that could be used to create an XSS attack for users on bad links. For example, the following URL illustrates this:

https://amigo-staging.geneontology.io/gannet?mirror=amigo_2_local_default&query=%3c%2ftextarea%3e%3cscRipt%3enetsparker(0x0067DA)%3c%2fscRipt%3e

Similar to https://github.com/geneontology/amigo/issues/575

kltm commented 3 years ago

Similarly: http://noctua-amigo.berkeleybop.org/gannet?query=%3C/textarea%3E%3Ca%20href=%22http://www.google.com%22%3E%3Ch1%3Eshould-not-be-seen%3C/h1%3E%3C/a

kltm commented 3 years ago

This looks to be cleared now.

kltm commented 3 years ago

New problematic example:

kltm commented 3 years ago

I think I got it.