search

geneontology / amigo

AmiGO is the public interface for the Gene Ontology.
http://amigo.geneontology.org
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Add line to substitute "+" for space to fix search and fix #592

Closed elserj closed 4 years ago

elserj commented 4 years ago

geneontology/amigo#585

elserj commented 4 years ago

I just tested your solution on our dev site, it works, but seems to add a bunch of extra "+" chars to the filter box. http://dev.planteome.org/amigo/search/ontology?q=plant%20cell Note how it changed it to "plant+++cell".

kltm commented 4 years ago

@elserj You have the correct solution then! Give us a PR and we'll take it. (I'll add a comment on your PR to tie it back to this ticket.)

elserj commented 4 years ago

Not sure what you mean, this is a PR... https://github.com/geneontology/amigo/pull/592

kltm commented 4 years ago

Yes, sorry. Can you make a branch on ours? I cannot make modifications as this is from your fork...I think. All I'm looking for is the text: 

## NOTE: This is a local fix for bookmarking in https://github.com/geneontology/amigo/issues/585 .
kltm commented 4 years ago

And, by the way, thank you for all of this work!

elserj commented 4 years ago

I did reference the ticket in the commit message, but if the correct method for this is to create my own branch on your repo and use that specific text, I can do that.

elserj commented 4 years ago

Oh, doesn't look like I have rights to create my own branch in your repo anyway, unless I am missing something.

elserj commented 4 years ago

I did add you as a contributor to my fork, so you should be able to make changes there if you want now as well.

kltm commented 4 years ago

@elserj Got it--thanks!