geneontology / amigo

AmiGO is the public interface for the Gene Ontology.
http://amigo.geneontology.org
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Create / produce additional GOlr fields to support default relation change #624

Closed kltm closed 2 years ago

kltm commented 2 years ago

There are fields in GOlr, like regulates_transitivity_graph_json, which seem to have been created after the initial switch from isa_partof to regulates and have no isa_partof analog. The schema will have to be extended and those would need to be added to the loader.

This is a spinoff from #620

kltm commented 2 years ago

Explicit metadata "regulates" fields: regulates_closure regulates_closure_label regulates_transitivity_graph_json

The last one is the problematic one. It is defined in only: neo-config.yaml and ont-config.yaml

kltm commented 2 years ago

As a technical "huh" note, given how we do this, we could be done this in the (relative) snap of the fingers if we forgive ourselves the field id "regulates_..." and just redefine it using the relation set we want.

  - id: regulates_transitivity_graph_json
    description: "JSON blob form of the local relation transitivity graph. Uses various relations (including regulates, occurs in, capable_of)."
    display_name: Regulates transitivity graph (JSON)
    type: string
    property:
      - "getLineageShuntGraphJSON"
      - "BFO:0000050"
      - "BFO:0000066"
      - "RO:0002211"
      - "RO:0002212"
      - "RO:0002213"
      - "RO:0002215"
      - "RO:0002216"
    indexed: false
kltm commented 2 years ago

Noting that topology_graph_json is defined as the regulates set of relations. Hm. I'm not sure what exactly that will have consequences for or if there will be an incompatibility. It's possible that that might have to be factored out with a set of two new fields mirroring the transitivity fields.

Similarly, I wonder what is loaded into "neighborhood_.." fields, as they are not exposed at all in the metadata and would required some owltools exploration. I don't believe they're used outside of a single minor sub-display on ontology pages that probably wouldn't be missed even if something did break, so will forge ahead ignoring that for now.

kltm commented 2 years ago

Should now have index building image with geneontology/golr-autoindex:f815e3e9004f96493f29a80a73526c91c2a4c25d_2021-10-01T162208_issue-620-change-default-closure Will test after release.

kltm commented 2 years ago

Bad SOP for docker build; updated and retrying.

kltm commented 2 years ago

I believe that this is now generally working. New tickets will be refinement or bug fixes.