geneontology / amigo

AmiGO is the public interface for the Gene Ontology.
http://amigo.geneontology.org
BSD 3-Clause "New" or "Revised" License
29 stars 17 forks source link

Refresh JS build system #680

Closed pkalita-lbl closed 1 year ago

pkalita-lbl commented 1 year ago

The changes here:

Fixes #676

kltm commented 1 year ago

@pkalita-lbl Okay, testing locally with sjcarbon@moiraine:~/local/src/git/amigo[issue-676]$:) ./node_modules/.bin/gulp build

The sub-command cd ./javascript/npm/amigo2-instance-data && npm install gives me the error:

ERROR:
Pinged: https://s3-us-west-1.amazonaws.com/go-amigo-usage-master/ping.json
/home/sjcarbon/local/src/git/amigo/javascript/npm/amigo2-instance-data/node_modules/npm/lib/utils/exit-handler.js:22
  const hasLoadedNpm = npm?.config.loaded
                           ^

SyntaxError: Unexpected token .

I suspect that you need to do to that sub-package what you did for in the mail package. If you'd like, and you have tylenol/whiskey available, I can walk you through why this aberration exists in the first place.

It could also be that I'm messing something else up at my end. Let me know if there is something else I should be doing.

pkalita-lbl commented 1 year ago

Hmm I don't see the same error while working in the amig-standalone container. It smells like some kind of version mismatch issue though. It's complaining about an optional chaining operator (?.). That was implemented in Node.js 14.0.0, and we're using Node.js 8.x (at least in the container). So for some reason your version of the npm package in amigo2-instance-data must be way ahead of where it should be. We should probably just meet to work through it instead of going back and forth in GItHub comments.

kltm commented 1 year ago

@pkalita-lbl After some cleaning locally, this worked for me in a non-docker environment, so I think this is good.

What do you think about updating the amigo-standalone image with newer code? I think we can punt on that until there is something "production-worth" to add, but it might help in your development?

Later on, we'll want to coordinate with @abessiari about getting this out to the production devops images.

pkalita-lbl commented 1 year ago

What do you think about updating the amigo-standalone image with newer code? I think we can punt on that until there is something "production-worth" to add, but it might help in your development?

I don't think it matters too much one way or the other for the development workflow I'm using, but I'd be happy to nonetheless. Maybe that's something to take on once more of the actual AmiGO UI work is done?

Later on, we'll want to coordinate with @abessiari about getting this out to the production devops images.

Yeah, please loop me in. I'm curious how all that works.