search

geneontology / geneontology.github.io

Repository for storing GO documentation, directly available through the general GO site
http://geneontology.org
MIT License
6 stars 10 forks source link

geneontology.github.io URL exposed in many cases where a "/" is not included at the end of the URL #369

Open suzialeksander opened 2 years ago

suzialeksander commented 2 years ago

I think this is unintentional, but trying to provide a user with a link to

geneontology.org/docs/downloads#doi-versioned-bundles

displays the address of

https://geneontology.github.io/docs/downloads/#doi-versioned-bundles

I think we wanted the .github.io bits hidden?? On FF 98.x

@kltm

suzialeksander commented 2 years ago

This might also have something to do with having been sent to the /downloads page from our search but I cannot reproduce

kltm commented 2 years ago

I would agree that’s like unintentional or an error. We would ideally not be exposing any non-canonical URL. That said, a relatively surface issue.

On Aug 23, 2022, at 12:46, suzialeksander @.***> wrote:

 I think this is unintentional, but trying to provide a user with a link to

geneontology.org/docs/downloads#doi-versioned-bundles

displays the address of

https://geneontology.github.io/docs/downloads/#doi-versioned-bundles

I think we wanted the .github.io bits hidden?? On FF 98.x

@kltm

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

kltm commented 1 year ago

Looking into this a little more. Basically, our proxy asks for a page, GH says "sure, found it" and sends a 301 redirect to the GH location, which the browser then follows. We would be able to get around this by doing one of the following: 1) Going all in on GH as our root domain (some peripheral outstanding problems w/going this way) 2) Make the proxy smarter so that the rewrite with the slash is made at our end, never giving GH a chance to do the wrong thing. 3) Try and get GH to do the right thing; not sure if possible yet If this is an issue, 2 is probably the fastest out the door.

kltm commented 1 year ago

@suzialeksander Noting that http://geneontology.org/docs/downloads/#doi-versioned-bundles does not have the forwarding issue as the URL has the slash that GH Pages likes at the end.

suzialeksander commented 1 year ago

to add, no external group/user has ever complained or noticed, so door 2 seems to be a good solution