geneontology / go-annotation

This repository hosts the tracker for issues pertaining to GO annotations.
BSD 3-Clause "New" or "Revised" License
34 stars 10 forks source link

cohesin complex update, matrix project #1490

Closed ValWood closed 5 years ago

ValWood commented 7 years ago

Update on the original ticket: https://github.com/geneontology/go-annotation/issues/1396

This is how the cohesin intersections look currently:

cohesin_complex_update

ValWood commented 7 years ago

outstanding issues:

Issues not previously reported:

chromatin organization

Cytoskeleton annotations remaining now the ontology issue is fixed

Regulation of cell cycle phase transition

@vanaukenk I'll use this e.g. and a couple of others for a future annotation call.

ValWood commented 7 years ago

moved to

https://github.com/geneontology/go-annotation/issues/1500

tberardini commented 7 years ago

@ValWood : Sorry, but I missed the context. Am I supposed to be reviewing the annotations to chromatin organization and cytoskeleton? Or specific kids?

hattrill commented 7 years ago

Have removed co-loc with cohesin complex for Sce as paper actually does not shown this. For 2008 paper for Nipped-B removed co-loc with cohesin complex (and added some cohesin loading/unloading terms for genes in this paper as more appropriate), but for 2010 paper they show co-loc staining with cohesin complex subunits but in an IP "none of the cohesin subunit precipitations brought down detectable amounts of Nipped-B". So, I will keep this one for now for and add it to #1500 as an example.

ValWood commented 7 years ago

The queried annotation is "mitotic spindle organization" WAPL1 and 2. WAPL is a cohesin binding protein and cohesin release factor. I read a lot of papers on this and I'm not aware of any other role. At TAIR it has "mitotic spindle organization", the evidence is IGI to each other?

I don't think that there is a direct role in spindle organization. Phenotypes show "mitotic spindle attachment defects", this is a downstream effect because of the defect in kinetochore assembly. Historically, spindle organization was (incorrectly) a parent of "mitotic spindle attachment". This might explain the annotation.

I would not even annotate this to "mitotic spindle attachment" its too far downstream....

Of course there may be entirely another reason for this annotation that I'n unaware of!

hattrill commented 7 years ago

Removed the co-locs for Nipped-B and pds5. Should be public beginning of Feb.

tberardini commented 7 years ago

I fixed the annotation for SYN1. @lreiser will look into the WAPL1/2 annotations.

lreiser commented 7 years ago

Val, yes, it was based on the figure showing the mutant phenotype (a downstream effect) and I have obsoleted the annotations for WAPL1/2. Must have been those nasty "alternative facts"

MakingGOGreatAgain

irony

ValWood commented 7 years ago

Hello,

This is how the cohesin complex annotation intersections look today:

![cohesin complex update figure] cohesin march 2017

I'm using this intersection as an example in a paper, along with some larger studies. Also Seth Carbon will be talking about the Matrix project as ISB later this month and will use this example. This is a final call for any annotation fixes... I can remove any "pending" annotation violations from the figure. Or, if you believe them to be correct I can extend the annotation rules.

I'll summarize the outstanding issues today below.

Thanks!

Val

ValWood commented 7 years ago

And today I did the final intersection, signalling which raised the following

ukemi commented 7 years ago

I looked at this paper again and changed the annotations from being a part of the cohesin and NuRD complexes to 'protein complex binding' with those complexes as inputs. Although it is a fine line about when something is part of a complex and when it binds the complex, in this case, I think the authors intent is to say that the protein interacts with the core complexes.

ValWood commented 7 years ago

Although it is a fine line about when something is part of a complex and when it binds the complex, in this case, I think the authors intent is to say that the protein interacts with the core complexes.

I agree, its sometimes tricky. In this case cohesin is a well defined complex but it has some transient interactors. Complex binding with extension works better (especially since these have been picked up by PAINt and Ensembl piplines and propagated)

ValWood commented 7 years ago

More outstanding

srengel commented 7 years ago

reading David's comment above, i will change this colocalizes_with to 'protein complex binding' with a col-16 entry. it seems that would be better.

ValWood commented 6 years ago

I think these are all done, but I noticed a new one

cohesion complex FB:FBgn0024188 san (N-acetyltransferase) cohesin complex (it acetylates a cohesion subunit but isn’t part of the complex per se (binding maybe) @hattrill could you take a look

Then I'll close this.

hattrill commented 6 years ago
pgarmiri commented 6 years ago
ValWood commented 5 years ago

closing. Cohesin complex now looks cleaned up. I opened tickets for a couple of remaining issues