geneontology / go-annotation

This repository hosts the tracker for issues pertaining to GO annotations.
BSD 3-Clause "New" or "Revised" License
35 stars 10 forks source link

Review direct annotations to 'cell population proliferation' #2204

Closed pgaudet closed 7 months ago

pgaudet commented 5 years ago

It has been proposed to make 'cell proliferation' a do_not_annotate term. Please review your annotations to make them more precise (or remove them if they represent a read out and the molecular mechanism by which the cell is involved in proliferation is not known).

ukemi commented 5 years ago

I disagree with this proposal. It is quite useful when context is given in annotation extensions. Do we want to instantiate a class for every cell type whose population can proliferate?

pgaudet commented 5 years ago

So, how about making a rule that the extension is mandatory?

pgaudet commented 5 years ago

@ValWood OK for you ?

ValWood commented 5 years ago

yep. I suggested here that extended terms would also be OK https://github.com/geneontology/go-ontology/issues/16659

hattrill commented 5 years ago

Probably take me a couple of weeks to get round to reviewing these.

pgaudet commented 5 years ago

Annotations to cell proliferation without extensions are here: https://docs.google.com/spreadsheets/d/1VG9gsN2al1WyH2cy4VMkt5kiC_CShbr44CgIBAsbVpM/edit#gid=0

Manual annotations by group:

Group  Number of annotations contact
AgBase 17 @
Alzheimers_University_of_Toronto 2 - checked but can't edit  @RLovering change to @pgarmiri
BHF-UCL 9 - done   @RLovering
CACAO 1  s>@sandyl27</s @dsiegele
dictyBase 3  @pfey03 (done ? please check/fill the spreadsheet)
FlyBase 54  @hattrill
GeneDB 15  @ggeorghiou
HGNC 3 - done  @RLovering
MGI 81  @hdrabkin
PINC 142  @pgaudet
RGD 35  @slaulederkind
TAIR 48  @tberardini
UniProt 162  @pgarmiri
WB 3  @vanaukenk
ZFIN 20  @sabrinatoro
ValWood commented 5 years ago

Wasn't the plan to have these be "soft checks" so that people could would work through them at their leisure

pgaudet commented 5 years ago

yes there is no emergency for these.

hdrabkin commented 5 years ago

As David points out we can use extensions with these terms, so this should not be made do not annotate. A rule could be made to require an extension if the term is used.

pfey03 commented 5 years ago

I'm done, commented on the wrong issue yesterday.

The Dicty EXP were legacy and have been updated to term we use currently. These Dicty 'growth' IMP went years ago to 'cell proliferation' and then to 'asexual reproduction', which those were updated to.

I also deleted the legacy dictyBase ISS annotations

vanaukenk commented 5 years ago

The WB annotations are done. I removed one and changed the other two to variations on mitotic cell cycle.

tberardini commented 5 years ago

@ebakker2 : Still working on getting you on the list for 'Assignees'. This is the ticket we were talking about earlier today.

sabrinatoro commented 5 years ago

ZFIN annotations are done. I added some annotation extensions, and removed some.

hdrabkin commented 5 years ago

MGI done

pgarmiri commented 5 years ago

The UniProt-EBI annotations have been checked and the actions reported in the spreadsheet.

There are 66 SWIS annotation left. I added a purple colored tag in end of each relevant row. (@sylvainpoux ) Thanks, Penelope

hattrill commented 5 years ago

FB done

pgaudet commented 5 years ago

@Achchuthan Can you please review the GeneDB genes ? The task is to either add an annotation extension or remove the annotation.

Achchuthan commented 5 years ago

Thanks @pgaudet. I have removed all Trypanosoma brucei and Leishmania major annotations from GeneDB. I have also emailed Uli to review Plasmodium annotations.

uliboehme commented 5 years ago

Thanks @Achchuthan. I have now removed the Plasmodium annotations from GeneDB. @pgaudet It would be really great if you could let me know in the future if there are any obsolete Plasmodium GO terms. Thanks!

pgaudet commented 5 years ago

Dear @uliboehme

This is the error report for Plasmodium falciparum :

http://current.geneontology.org/reports/genedb_pfalciparum-report.html

These get updated about once a month, so you can check periodically if new errors have been detected.

Thanks, Pascale

uliboehme commented 5 years ago

Dear @pgaudet,

Thanks for your reply. I was not aware of this link.

Could you also please add me as contact for GeneDB (in addition to @Achchuthan).

Thanks very much. Uli

dsiegele commented 2 years ago

I decided to leave the annotation in CACAO until I discuss it further. I removed the annotation in CACAO. The paper (Figure 1A may have evidence for regulation of cell population proliferation, but the experiment tested overexpression of MOUSE:BOP1 in cell lines so I am not sure about it.

pgaudet commented 2 years ago

@dsiegele In this case I think the authors are testing the viability of the cells with and without the proper factors to process the ribosomal RNA. I dont think these genes are directly involved in cell proliferation.

Pascale