search

geneontology / go-annotation

This repository hosts the tracker for issues pertaining to GO annotations.
BSD 3-Clause "New" or "Revised" License
31 stars 10 forks source link

UniProt IDs should be of type 'protein-coding gene' in the GPI file(s) #2955

Closed pgaudet closed 4 years ago

pgaudet commented 4 years ago

Hi @alexsign

To be consistent with the GO-Shapes/ShEx, we need to have the UniProt IDs that represent gene-centric reference protein (GCRP) accession of type 'protein-coding gene' , SO:0001217, and not protein.

Thanks, Pascale

alexsign commented 4 years ago

@pgaudet not sure what is issue about? ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/UNIPROT/goa_uniprot_gcrp.gpi.gz should have GCRP accessions of type 'protein-coding gene', unless something went wrong on during the assignment.

pgaudet commented 4 years ago

OK thanks @alexsign @vanaukenk I think we're all good ? The ShEx should not create incorrect inferences anymore if this is taken into account, right ?

Thanks, Pascale

pgaudet commented 4 years ago

@RLovering in case you want to follow the discussion

pgaudet commented 4 years ago

Thanks @alexsign ! I should have checked before opening a ticket.