geneontology / go-annotation

This repository hosts the tracker for issues pertaining to GO annotations.
BSD 3-Clause "New" or "Revised" License
35 stars 10 forks source link

rpn15 #4542

Closed ValWood closed 9 months ago

ValWood commented 1 year ago

DisProt:

rpn15 multifunctional proteasome assembly, lid subcomplex subunit Rpn15/Dss1 GO:0043167 ion binding ChEBI ID | CHEBI:3312 calcium dichloride

might be better to do as "calcium ion binding" rather than ion binding + CHEBI

@pgaudet what do you think?

ValWood commented 1 year ago

@pgaudet should I close this one? But it seems odd to post compose with an extension if we have the term? https://www.uniprot.org/uniprotkb/O14140/entry especially since UniProtKB does not display extensions

pgaudet commented 9 months ago

@victorianugnes Can you please check if this annotation can be updated?

ValWood commented 9 months ago

I will add "ion binding" to the do not annotate list.

pgaudet commented 9 months ago

We may not have all possible ions in the ontology; I guess you can do that and we can see what fails...

the issue is, many groups dont look at these, so we dont really know the impact.

victorianugnes commented 9 months ago

Hi, we will update this annotation to calcium ion binding. We do have other annotations regarding the term GO:0043167 ion binding. We will look to update these to more specific terms. Might take us some time but I'll let you know when it's done

pgaudet commented 9 months ago

Thanks @victorianugnes !

deustp01 commented 9 months ago

rpn15 multifunctional proteasome assembly, lid subcomplex subunit Rpn15/Dss1 GO:0043167 ion binding ChEBI ID | CHEBI:3312 calcium dichloride

might be better to do as "calcium ion binding" rather than ion binding + CHEBI

Tangential issue: however GO handles functions involving ions, shouldn't the ChEBI part point to the ion, Ca++ in this case, not to a salt of it CaCl2?

ValWood commented 9 months ago

the issue is, many groups don't look at these, so we dont really know the impact.

pgaudet commented 9 months ago

@deustp01 very good point, people often annotate to the chemical used in the materials and methods of the paper, and not to the relevant ion/molecule.

Using the GO term will resolve at least this instance.