geneontology / go-fastapi

https://api.geneontology.org/
4 stars 3 forks source link

handling cloudflare #59

Closed abessiari closed 11 months ago

abessiari commented 11 months ago

Handling support for Cloudflare. it is optional.

abessiari commented 11 months ago

@kltm @sierra-moxon

FYI: The handling of Clouldflare is mainly in the the apache proxy image (v6) The changes are used to capture the real client ip in the apache logs.

GITHUB https://github.com/geneontology/devops-apache-proxy

DOCKERHUB: https://hub.docker.com/repository/docker/geneontology/apache-proxy/general

sierra-moxon commented 11 months ago

Hi @abessiari - I am not sure why this doesn't automatically try and merge in main changes and re-run the tests (I fixed up the tests that have been failing this afternoon). Could you please merge main into your fork and push the changes up so we can confirm that the tests pass again with these changes?

(I also gave you branch permission on this repo, as even with the "Maintainers are allowed to edit this pull request" setting enabled, thank you, I can't see an easy way to force a main branch merge here without forking off your fork).

abessiari commented 11 months ago

@sierra-moxon The tests passed.