Gorest2021 issue 6 - Githubissues

geneontology / go-fastapi

https://api.geneontology.org/

4 stars 3 forks source link

Gorest2021 issue 6 #85

Closed sierra-moxon closed 8 months ago

sierra-moxon commented 8 months ago

bypass barista call in favor of using the pre-computed JSON files that represent gocams here: https://go-public.s3.amazonaws.com/files/go-cam/
fixes https://github.com/geneontology/api-gorest-2021/issues/6

kltm commented 8 months ago

Not sure about the failed tests, but I'm happy to have these self-merged when done.

pkalita-lbl commented 8 months ago

Is there a convention to accept either prefixed IDs (gomodel:568b0f9600000284) or bare (568b0f9600000284) or both? I think as it stands this will only accept bare IDs.

kltm commented 8 months ago

Interesting question. I am more comfortable using All CURIEs All The Time, but I understand the original intent of having the ID sans-namespace, as it is already in a GO-CAM route. I guess ideally both at this point then?

sierra-moxon commented 8 months ago

sure; I can add support for gomodel: prefixed ids.