geneontology / go-fastapi

https://api.geneontology.org/
4 stars 3 forks source link

refactor SPARQL to be faster and just return models by taxon id #97

Closed sierra-moxon closed 2 weeks ago

sierra-moxon commented 2 weeks ago

edit: fixes #94

sierra-moxon commented 2 weeks ago

Thanks @balhoff - I'm sorry the PR got so unwieldy - I was trying all sorts of things to get the GH actions to pass. I mostly wanted your feedback on the SPARQL changes. Thank you for sorting through these 29 file changes for the relevant bits to review. I appreciate it!

balhoff commented 2 weeks ago

Thanks @balhoff - I'm sorry the PR got so unwieldy - I was trying all sorts of things to get the GH actions to pass. I mostly wanted your feedback on the SPARQL changes. Thank you for sorting through these 29 file changes for the relevant bits to review. I appreciate it!

That's what I figured! The SPARQL is pretty different now but I think I see that it should work.