geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
223 stars 40 forks source link

chromatin silencing at subtelomere #12841

Closed mah11 closed 7 years ago

mah11 commented 7 years ago

I based all of this on GO:0006348. GO doesn't have a CC term for subtelomeric region, but SO has a subtelomere term (pasted below). Not urgent, but will make the set of 'silencing at X' - and our phenotypes reflecting same - more complete.

id: GO:new name: chromatin silencing at subtelomere namespace: biological_process def: "Repression of transcription of subtelomeric DNA by altering the structure of chromatin." [PMID:22771823, PMID:26205977] synonym: "heterochromatic silencing at subtelomere" EXACT [] synonym: "subtelomere chromatin silencing" EXACT [] synonym: "subtelomeric silencing" EXACT [] is_a: GO:0006342 ! chromatin silencing

[Term] id: SO:0001997 name: subtelomere def: "A heterochromatic region of the chromosome, adjacent to the telomere (on the centromeric side) that contains repetitive DNA and sometimes genes and it is transcribed." [POMBE:al] is_a: SO:0000628 ! chromosomal_structural_element

srengel commented 7 years ago

do we really need this new term? can't this be chromatin silencing occurs_at subtelomere in col16?

mah11 commented 7 years ago

In principle, almost anything that can have a logical definition can be done either way.

In practice, it makes sense to handle the subtelomere the same way as other chromosome parts, genomic regions, and sequence features. These existing GO terms provide precedent (and if this new term is not added, there'd be a strong case for making them obsolete):

GO:0000183 chromatin silencing at rDNA GO:0006348 chromatin silencing at telomere GO:0030466 chromatin silencing at silent mating-type cassette GO:0030702 chromatin silencing at centromere GO:1990141 chromatin silencing at centromere outer repeat region

dosumis commented 7 years ago

@mah11 - agreed

In fact we already have logical defs for these:

GO:1990141 chromatin silencing at centromere outer repeat region 'chromatin silencing' and ('occurs in' some 'chromosome, centromeric outer repeat region') # Note - we've never allowed occurs_at in the ontology.

I'll add the new term following this pattern.

srengel commented 7 years ago

ok, but just because precedent has been set years ago doesn't mean it's the way to move forward at this point in time.

mah11 commented 7 years ago

But whichever approach we deem better now should be deployed consistently, not just to new term requests (i.e. older terms may need to be retrofitted).

I don't actually have a strong preference for precomposed GO terms for silencing at X (I can adapt FYPO terms to either); I only want them handled consistently for all values of X.

srengel commented 7 years ago

agreed.

dosumis commented 7 years ago

In this case the pattern does a small amount of useful work in the ontology that you wouldn't get from an extension:

image

The placement of the class in blue is automated by the pattern. Explanation:

image

The terms are also clear, so I see nothing wrong with them being in the ontology. I'd much rather target big opaque compound terms for removing from the ontology in favor of extensions/LEGO.

dosumis commented 7 years ago

Added the new GO process term. We should probably also add subtelomere to CC. Need to look into how we should link this and similar terms to SO.

dosumis commented 7 years ago

Addes subtelomere to GO. Opened ticket on resolving GO-SO issues: #12845