geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

TPV chromatin -> macromolecular complex #12916

Closed ValWood closed 7 years ago

ValWood commented 7 years ago

This doesn't look right does it?

ValWood commented 7 years ago

includes terms like "heterochromatin island" and "telomeric heterochromatin"

ukemi commented 7 years ago

Looks right to me. Macromolecular complex will become protein-containing complex once I do the edits in #12782.

ValWood commented 7 years ago

I don't think many biologists would call a "heterochromatin island" a "macromolecular complex". I think because its a "chromosome part" which cannot exist independently of a chromosome.

We would end up calling everything in a cell a "macromolecular complex".....

ValWood commented 7 years ago

I have another problem with this. It is really just a different structural representation of a chromosomal region due to histone modifications.....and it could never be defined in terms of subunit composition (its too variable in its formation and extent).

bmeldal commented 7 years ago

I'm with Val on the problem of where to draw the line but I also can't see the term in the ontology so can't see the def.

ukemi commented 7 years ago

chromatin- The ordered and organized complex of DNA, protein, and sometimes RNA, that forms the chromosome. (should probably be renamed 'chromosomal chromatin').

macromolecular complex- A stable assembly of two or more macromolecules, i.e. proteins, nucleic acids, carbohydrates or lipids, in which at least one component is a protein and the constituent parts function together.

ukemi commented 7 years ago

I removed the macromolecular complex parent and now chromatin is just a chromosomal part.

bmeldal commented 7 years ago

What does TVP stand for? - Just for future ref. Or was it supposed to be TPV - true path violation?

ValWood commented 7 years ago

corrected!