geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

NTR: L-aspartate import & D-aspartate transmembrane transporter activity #13150

Closed BarbaraCzub closed 7 years ago

BarbaraCzub commented 7 years ago

Re: Noctua model SynGO #1. I would like to request new terms to annotate Figure 4 from PMID:7914198.

NTR1: L-aspartate import This would be a child of: GO:0043092 L-amino acid import and GO:0070778 L-aspartate transport

NTR2: D-aspartate transmembrane transporter activity This would be a child of: GO:0015172 acidic amino acid transmembrane transporter activity and GO:0005310 dicarboxylic acid transmembrane transporter activity and GO:0070777 D-aspartate transport (perhaps D-aspartate transmembrane transport should be created too) and GO:0042943 D-amino acid transmembrane transporter activity

Thanks, Barbara

@RLovering @thomaspd

GOC:bc GOC:SynGO-UCL

BarbaraCzub commented 7 years ago

Thank you @pgaudet for having created the GO:0140010 D-aspartate transmembrane transporter activity MF term.

However, I don't think the 'L-aspartate import' BP term has been created yet? Or is it being processed?

I imagine it should fit into its ontology branch similarly to how the 'D-asparte import' and 'L-glutamate import' terms do. Atm, a more specific GO term 'L-aspartate import across plasma membrane' exists, but there seems to be no 'L-aspartate import' on its own.

screen shot 2017-03-21 at 10 15 16

BarbaraCzub commented 7 years ago

Actually, could I please request '[specific amino acid] transmembrane import' terms (which would become children of GO:0044745) for L-aspartate, D-aspartate and L-glutamate? @dosumis has just pointed out that these would be more relevant to the experiment being annotated, as the 'import' terms on their own are not children of 'transmembrane transport', which is what the experiment is showing.

pgaudet commented 7 years ago

Hi Barbara,

I didn't create 'L-aspartate import' because I thought you meant 'L-aspartate import across the plasma membrane'. Can you please specify across which membranes the amino acids re being transported ?

Thanks, Pascale

BarbaraCzub commented 7 years ago

Hi Pascale,

All three amino acids L-aspartate, D-aspartate and L-glutamate, evaluated in the annotated experiments, are imported into Xenopus oocytes across their plasma membrane, which is enabled by human SLC1A1 (Figure 4 from PMID:7914198).

I did not annotate using the term 'L-aspartate import across the plasma membrane', because I wanted to be consistent with use of the three amino acid transport terms, and atm I have no such option, because (unlike 'L-aspartate import across the plasma membrane'), 'D-aspartate import' and 'L-glutamate import' are not children of 'amino acid transmembrane import'.

Therefore, I requested '[specific amino acid] transmembrane import' terms, as 'D-aspartate transmembrane import' is more specific than 'D-aspartate import', and similarly 'L-glutamate transmembrane import' is more specific than 'L-glutamate import'. Whereas 'L-aspartate transmembrane import' could become a parent of 'L-aspartate import across the plasma membrane'. But if we need to specify the membrane type for 'D-aspartate import' and 'L-glutamate import', then let's use the template: '[amino acid] import across the plasma membrane', and leave the ontology branch of 'L-aspartate import across the plasma membrane' as it is.

Thanks, Barbara

pgaudet commented 7 years ago

Hi Barbara,

Thanks for the clarification. This part of the ontology is probably more complicated than it should be. As far as I know, all import of specific molecules such as amino acids occurs across the plasma membrane, and is a transmembrane transport. So I would like to merge the terms 'x import into cell'/ with 'x import across plasma membrane', and make the parents more consistent. Would that address your request ?

Thanks, Pascale

BarbaraCzub commented 7 years ago

Hi Pascale,

I suppose it is a good idea to merge 'amino acid import into cell' with 'amino acid import across plasma membrane', but 'L-glutamate import' and 'D-aspartate import' are not children of this branch (screenshot below), and they probably should be, so further rearrangements in the ontology would be needed to ensure that they become siblings with 'L-aspartate import...' rather than (slightly distant) cousins.

Thanks, Barbara

25bb6840-0e20-11e7-959e-a3b6c5e2db6d

pgaudet commented 7 years ago

Yep ! agreed.

pgaudet commented 7 years ago

How does that look ?

image
BarbaraCzub commented 7 years ago

I'm assuming 'D-aspartate import...' is further down?

dosumis commented 7 years ago

Few notes:

BarbaraCzub commented 7 years ago

I suppose for macromolecules the distinction between import into cell and import across the PM would be maintained as macromolecules are higher up in the ontology than amino acids?

BarbaraCzub commented 7 years ago

Ok, actually, I cannot find a macromolecule import term at all.

pgaudet commented 7 years ago

Thanks @dosumis In fact there were a few subclasses, and some discrepancies in the logical definitions I came across. I used this pattern everywhere: transport and ('has target start location' some 'extracellular region') and ('has target end location' some cytosol) and (imports some amino acid) and ('results in transport across' some 'plasma membrane')

The correct subclasses seem to have been inferred.

pgaudet commented 7 years ago

Hi @BarbaraCzub

I hasn't created the new term yet. How does that look ?

image
BarbaraCzub commented 7 years ago

Looks good to me!

pgaudet commented 7 years ago

Hello @dosumis When you have some time would you please check this - and let me know if I can merge?

Thanks, Pascale

ValWood commented 7 years ago

I agree that the intermediate terms are not useful. We have no evidence that amino acid transport occurs via any mechanism than TM transport. It is unlikely to occur via endocytosis/exocytosis. This is the mechnaism to deal with the PM transporters themselves. (and if some other mechanism does turn up we can deal with that property later).

My only request is that we keep the "transmembrane" term names for consistency http://pombase2.aska.gen.nz/term/GO%3A0055085 (and because it is good to know at a glance, there are some molecule transporters which are not transmembrane)

pgaudet commented 7 years ago

Hi Val,

I'll fix all these, the goal is that there won't be any orphans when this is done.

Pascale

pgaudet commented 7 years ago

Hi @BarbaraCzub

The terms you need should now be in the ontology. Please let me know if you see any issues.

Thanks, Pascale

BarbaraCzub commented 7 years ago

Hi @pgaudet

Thanks for the update.

I have found:

But I have not been able to find 'D-aspartate import across plasma membrane'. Perhaps this has not updated yet? (It is on your latest screenshot).

Thanks, Barbara

pgaudet commented 7 years ago

Hi Barbara,

I don't see it in Protein2GO/QuickGO, but the term is in AmiGO. http://amigo.geneontology.org/amigo/term/GO:0140016

@tonysawfordebi : can you remind me when the EBI tools are updated?

Thanks,

Pascale

RLovering commented 7 years ago

You should be able to use these terms in QuickGO even if it doesn't display the GO term name

BarbaraCzub commented 7 years ago

Thanks @pgaudet This is useful to know. However, something is still not right, as the term is not searchable in Noctua. I would have thought that Noctua would pick it up, if it has been indexed in Amigo? Is this something we should check with Seth? (@RLovering it was a different term that I contacted QuickGO helpdesk about, which did not have the name displayed, even though the GO term number was visible in the ontology). Barbara

dosumis commented 7 years ago

All of these pipelines take time. QuickGO usually 2-3 days at least in my experience.

BarbaraCzub commented 7 years ago

Hi @dosumis I agree these pipelines take time, but I would imagine that all of the new terms would become available at the same time. Why two of them became available immediately in several resources (including Noctua), and one only appears in Amigo but nowhere else? But perhaps these terms 'take different routes'. Let's wait and see!

pgaudet commented 7 years ago

Looks like D-aspartate import across plasma membrane is now in P2GO.

kltm commented 7 years ago

Okay, to follow up on the availability of GO:0140010 and GO:0140016 in various GO resources. Both are available in AmiGO, which makes sense as it was last refreshed a few days ago.

However, the development loads of "AmiGO", including the one that drives Noctua, were in suspension for the last week plus due to them being made ready to act as failover for a spotty machine at the production site.

It looks like production is on an even keel again, so I will trigger these builds tonight.

BarbaraCzub commented 7 years ago

Hi @kltm

Something has certainly happened, as now the GO term names completely disappeared from my model for: GO:0140009 L-aspartate import across plasma membrane; and GO:0140010 D-aspartate transmembrane transporter activity. The GO term IDs appear to be displayed instead... screen shot 2017-04-11 at 13 14 42

However, the term 'GO:0140009 L-aspartate import across plasma membrane' is still not searchable in Noctua.

But perhaps whatever you triggered is still in progress?

BarbaraCzub commented 7 years ago

Hi @kltm

Similarly to the model which I mentioned above (this actually was: SynGO no. 1a) I have just noticed a similar problem in this model: SynGO no. 1c

screen shot 2017-04-11 at 16 48 52

Here the 'GO:0099054 presynapse assembly' term is displayed as only the GO term ID, whereas the term name is displayed for all other terms.

dosumis commented 7 years ago

I’ve been noticing general flakiness in GO term autocomplete this afternoon. Was halfway through writing a bug report when it fixed itself. Autocomplete on all other OBO terms seems to be working fine.

On Apr 11, 2017, at 4:49 PM, BarbaraCzub notifications@github.com wrote:

Hi @kltm https://github.com/kltm Similarly to the model which I mentioned above (this actually was: SynGO no. 1a) I have just noticed a similar problem in this model: SynGO no. 1c

Here the 'GO:0099054 presynapse assembly' term is displayed as only the GO term ID, whereas the term name is displayed for all other terms.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/geneontology/go-ontology/issues/13150#issuecomment-293307227, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG4xz1okZSalROhw7thmd847-RpMsycks5ru6EmgaJpZM4MZf1c.

BarbaraCzub commented 7 years ago

Thanks for the info @dosumis Unfortunately my autocomplete issues have not resolved themselves. In fact new ones (which can be seen in the same Nactua model 'SynGO no. 1c') have emerged since I sent the last message.

kltm commented 7 years ago

@cmungall nakama and NEO GOlrs had successful loads last night. Please compare: http://amigo.geneontology.org/amigo/search/ontology and: http://amigo2.berkeleybop.org/amigo/search/ontology

cmungall commented 7 years ago

Noctua issued moved here: https://github.com/geneontology/noctua/issues/411