geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

GO:0005487 - nucleocytoplasmic transporter activity parent #14336

Closed ValWood closed 6 years ago

ValWood commented 6 years ago

GO:0005487 nucleocytoplasmic transporter activity is a "molecular carrier activity"

not "protein transporter activity"

see https://github.com/geneontology/go-ontology/issues/14331 https://github.com/geneontology/go-ontology/issues/14221

pgaudet commented 6 years ago

@rachhuntley let me know if this addresses the point you raised.

Thanks, Pascale

bmeldal commented 6 years ago

Typo:

GO:0005049 : ...to mediate transport of a the cargo through the nuclear pore, from the nuclear to the cytoplasm.

should be nucleUS

(Sorry, I'm late to the part due to time off)

pgaudet commented 6 years ago

Hi @bmeldal Thanks for reporting this ! In fact I meant 'nuclear lumen'; is that OK ?

I also added logical definitions as follows:

Thanks, Pascale

ValWood commented 6 years ago

Hi Pascale, it should be nucleus, not nuclear lumen. The cargo is moving from the nucleus to the cytoplasm or vice versa but it isn't crossing the "nuclear envelope lumen"

This seems "unimportant" but if you think of the nuclear lumen as continuous with the ER it makes more sense why we need to keep these separate. The nuclear lumen is continuous with the ER and the cytoplasm is continuous with the nucleus.

There are very precise ways to get into the lumen. I think this makes it clearer than my previous explanations as it shows the broader context, not only the nuclear pore:

lumen

mah11 commented 6 years ago

Nuclear lumen =/= nuclear envelope lumen, and I don't see a problem with using nuclear lumen in this def.

ValWood commented 6 years ago

Ah OK, I never see the use of this phrase only "nuclear envelope lumen" ignore.

pgaudet commented 6 years ago

Thanks for the clarification @mah11 I was trying to say this the cargo does inside the nucleus, and not to the envelope, for example.

All good ?

Thanks, Pascale

ValWood commented 6 years ago

Is it really a "lumen"? I don't find any reference to "nuclear lumen" except in GO and a "lumen" is a "cavity within a tubular structure"

pgaudet commented 6 years ago

well - that's another story. It was there so I have been using it !

ValWood commented 6 years ago

I think it would be confusing to use just "lumen" Everything I can find about "nuclear lumen" is referring to "nuclear envelope lumen.

lumen

If we use lumen it will become even more difficult to keep this from being confused with transmembrane transport. Could you use from the "nucleoplasm" if you don't want to use from the "nucleus" ?

mah11 commented 6 years ago

"Lumen" is not restricted only to tubular structures - definitions I've found, including OED, say "The central cavity of a tubular or other hollow structure in an organism or cell."

"Nuclear lumen" doesn't seem to be a commonly used phrase, and I don't really care whether it stays in the GO definition or not, but its meaning is unambiguous.

ValWood commented 6 years ago

It would be good to find an example of it's use in this context if we keep it.

ValWood commented 5 years ago

Note that last week "nucleocytoplasmic transporter" reverted to being a transporter not a carrier. Although people call it a carrier, it isn't a carrier in the GO sense, it's a transporter.

@pgaudet can you link this to the ticket documenting the change, I can't find it. I'm still a little confused by exactly what classifies as "carrier" do it would be good to have a trail for this.

pgaudet commented 5 years ago

There was no ticket yet - thanks for the reminder ! Here: https://github.com/geneontology/go-ontology/issues/17399