geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
223 stars 40 forks source link

'response to chemical' parentage? #16572

Closed tberardini closed 5 years ago

tberardini commented 6 years ago

Right now, response to chemical is a direct child of response to stimulus.

image

@lreiser and I think that it could make sense to move the parentage down one so that response to chemical is a direct child of response to abiotic stimulus.

image

http://amigo.geneontology.org/amigo/term/GO:0050896#display-lineage-tab

The definitions of the biotic/abiotic stimulus terms follow.

Def of 'response to abiotic stimulus': Any process that results in a change in state or activity of a cell or an organism (in terms of movement, secretion, enzyme production, gene expression, etc.) as a result of an abiotic (non-living) stimulus.

All chemicals are non-living. Makes sense to place them here. (Water, oxygen are already here.)

Def of 'response to biotic stimulus': Any process that results in a change in state or activity of a cell or an organism (in terms of movement, secretion, enzyme production, gene expression, etc.) as a result of a biotic stimulus, a stimulus caused or produced by a living organism.

Many chemicals are produced by living organisms. Makes sense for some chemicals to be here.

These two definitions are not mutually exclusive. Can someone clarify please? It could be that 'response to abiotic stimulus' needs to be more tightly defined. I tried digging into old GH and SF tickets but couldn't zero in on the decision to split out 'response to chemicals' but I suspect it might have something to do with the chemical split above.

ukemi commented 6 years ago

It seems that there are many axes of classification here: biotic versus abiotic, endogenous versus exogenous, etc. Amelia brought up issues with this long ago and these terms have always been a bit problematic (in my opinion). I have always gone the route of co-annotation for these terms, but I must admit I don't like to use them unless I know an exact mechanism.

ukemi commented 6 years ago

I think the response to chemicals was probably a result of the cross-product work that we did long ago. They are easy to factor out based on ChEBI.

pgaudet commented 6 years ago

Are these grouping terms necessary ? We could probably obsolete '(cellular) response to biotic stimulus' (272 EXP, mostly IMP by CGD) and (cellular) response to abiotic stimulus' (7 EXP annotations).

I dont think these add much structure to the ontology.

deustp01 commented 6 years ago

Estrogens are chemicals synthesized by cells in response to biotic stimuli. Where do they go in the new scheme? This looks like a good example in support of Pascale's suggestion just now - trying to divide stimuli cleanly and intuitively into two classes is really hard and we don't get much for it.

ukemi commented 6 years ago

There is really no new scheme. Amelia had the same issue with proteins or peptides that are receptor ligands. I think one of her questions was whether or not all signaling pathways should be housed here.

srengel commented 6 years ago

i agree that it is problematic to put response to chemicals under response to abiotic (def = not made by living organism) stimulus because some chemicals are made by living organisms (Peter's estrogen example) so by definition are not 'abiotic'.

we don't annotate to response to chemicals at SGD. we put all that stuff in phenotypes.

tberardini commented 6 years ago

@srengel

i agree that it is problematic to put response to chemicals under response to abiotic (def = not made by living organism) stimulus because some chemicals are made by living organisms (Peter's estrogen example) so by definition are not 'abiotic'.

The definition of 'response to abiotic stimulus' does not explicitly say "not made by living organism". The current definition ends with "...as a result of an abiotic (non-living) stimulus." This is why I suggested that 'response to abiotic stimulus' needs to be more tightly defined. (see above)

A more explicit def of 'response to abiotic stimulus' would clarify why 'response to chemical' is not a child of that term.

srengel commented 6 years ago

Hi @tberardini i wasn't talking about the definition of the term, but rather the definition of the word 'abiotic', which is 'not made by a living organism'. i thought you suggested making response to chemical a child of response to abiotic stimulus. perhaps i misunderstood. i agree with you that a more explicit def of 'response to abiotic stimulus' would be good.

tberardini commented 6 years ago

@srengel Ah yes. Got it. Thanks.

I suggest "...as a result of an abiotic (not derived from living organisms) stimulus."

Actually, do response to oxygen stimulus and response to water (better as response to water stimulus, currently a synonym) belong under 'response to abiotic stimulus' then? They are by-products of photosynthesis.

pgaudet commented 6 years ago

Let's get rid of these terms? They seem to create confusion more than anything.

tberardini commented 6 years ago

Let's get rid of these terms?

Which ones?

pgaudet commented 6 years ago

See my comment avove:

We could probably obsolete '(cellular) response to biotic stimulus' (272 EXP, mostly IMP by CGD) and (cellular) response to abiotic stimulus' (7 EXP annotations).

tberardini commented 6 years ago

@pgaudet : Checking: just the cellular versions or all four? Note that both non-cellular versions are used as slim terms. They are also marked as 'do_not_manually_annotate'. We (plant) find them useful as slim terms and would like to keep them.

subset: goslim_metagenomics subset: goslim_plant

pgaudet commented 6 years ago

Hi Tanya,

I just checked the annotations to plant genes to these terms.

RESPONSE TO ABIOTIC STIMULUS ALL EVIDENCE CODES (3592) response to external biotic stimulus (3592) response to external stimulus (3586) response to other organism (2838) defense response (2827) defense response to other organism

EXP ONLY (1819) response to external biotic stimulus (1813) response to other organism

cellular response to biotic stimulus (only EXP available) (7) cellular response to molecule of bacterial origin (3) cellular response to external biotic stimulus (2) positive regulation of autophagy in response to ER overload (1) ER overload response (1) lipopolysaccharide-mediated signaling pathway

RESPONSE TO ABIOTIC STIMULUS They fall in two general classes (see annotations here: https://docs.google.com/spreadsheets/d/1XvZ60fCi0Q30Vi2IxsouTCoShY3PkgSa1q7LNL_OpbI/edit?usp=sharing - note there are multiple sheets)

Note that 'response to stress' is also in the plant slim. Response to stress includes both biotic stress and abiotic stress, so it must contain almost the same annotation as 'response to biotic stimulus' + response to abiotic stimulus'


Personally I would put the plant slims to these terms:

The most useful class under response to biotic stimulus is 'GO:0051707 response to other organism', but most annotations are already under 'response to stress', via 'defense response to other organism', so I don't know if that's useful or not.

@valwood may have some insights to add about useful slimming classes.

Thanks, Pascale

image
ValWood commented 6 years ago

I agree with your suggestion. I would avoid "response to bioltic stimulus" particularly as is is an ancestor of response to stress.

I try to avoid "response to" terms in slims because they are used very badly for general chemical sensitivities when nothing is known.

At PomBase we now only use in extensions to extend the real process.

So we would do GO:0051403 stress-activated MAPK cascade part_of response to oxidates stress or GO:0043556 regulation of translation in response to oxidative stress (which we could post compose)

We try to nail down the process, so we don't have "response to stress" in the general, or Pombase slim except for

"response to toxic substance" is the only response to term in the generic slim I am building. I plan to remove this term when the gene products it currently pulls in are annotated correctly to aspects of "detoxification".

Sorry this isn't much help. I think you are correct that is is better to split these rather than lump because they are quite different.

@tberardini do you find that a lot of things do not slim at all if you leave out "response to stress"?

selewis commented 6 years ago

@cmungall - couldn't "stresses" (or stressing or causes_stress) be consider a relationship type between some external environmental factor (i.e. from EnvO or ChEBI or some external ontology). It does seem like we're handling this incorrectly and it would perhaps be wise to step back and consider another way of handling responses to various types of stress. I'm thinking back to Scott Gilbert's book on development.

ValWood commented 6 years ago

I see a nice example this morning. ERG6 gene is essential for stress adaptation in Kluyveromyces lactis. We investigated the effect of Kluyveromyces lactis ERG6 gene deletion on plasma membrane function and showed increased susceptibility of mutant cells to salt stress, cationic drugs and weak organic acids. Contrary to Saccharomyces cerevisiae, Klerg6 mutant cells exhibited increased tolerance to tunicamycin. The content of cell wall polysacharides did not significantly vary between wild-type and mutant cells. Although the expression of the NAD+- dependent glycerol 3-phosphate dehydrogenase (KlGPD1) in the Klerg6 mutant cells was only half of that in the parental strain, it was induced in the presence of calcofluor white. Also, cells exposed to this drug accumulated glycerol. The absence of KlErg6p led to plasma membrane hyperpolarization but had no statistically significant influence on the plasma membrane fluidity. We propose that the phenotype of Klerg6 mutant cells to large extent was a result of the reduced activity of specific plasma membrane proteins that require proper lipid composition for full activity.

Would often become annotated to "response to stress" when a defect makes cells more sensitive to stresses. but the process for erg6 should be "ergosterol biosynthetic process" (not sure if from this paper) with a "stress sensitivity" phenotype. Mess with the membrane, indirectly increase stress sensitivity.

Of course, there are also real stress response pathways and processes, but these should be more clearly described in the ontology

tberardini commented 6 years ago

@ValWood - Thanks for the suggestions. I was confused by this:

I agree with your suggestion. I would avoid "response to bioltic stimulus" particularly as is is an ancestor of response to stress.

This is the current relationship that I see:

image

It would be great to continue discussion good slimming practices :) outside of this GH ticket. I'll email you.

tberardini commented 6 years ago

I think, then, that the only immediate action necessary from my perspective is to expand the definition of 'response to abiotic stimulus' to be:

Any process that results in a change in state or activity of a cell or an organism (in terms of movement, secretion, enzyme production, gene expression, etc.) as a result of an abiotic (not derived from living organisms) stimulus.

With that done, we could close this issue. Thanks, everyone, for your suggestions on slimming.

ValWood commented 6 years ago

@ValWood - Thanks for the suggestions. I was confused by this: yes I misread the ontology

happy to chat about slims some time.