geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

fix taxon restriction 'iron ion import across cell outer membrane' #16829

Closed ValWood closed 5 years ago

ValWood commented 5 years ago

'iron ion import across cell outer membrane' SubClassOf 'only in taxon' some Bacteria

from https://github.com/geneontology/go-ontology/issues/16776

ukemi commented 5 years ago

Since both organelles and bacteria can have outer membranes, I will remove the TR.

-D

ValWood commented 5 years ago

This term is still unavailable to us?

ukemi commented 5 years ago

Looks like it is coming from the restriction on 'cell envelope'. Are you sure you want the 'cell outer membrane' taxon restriction removed? 'Cell outer membrane' is a part_of 'cell envelope'.

Cell outer membrane: A lipid bilayer that forms the outermost membrane of the cell envelope; enriched in polysaccharide and protein; the outer leaflet of the membrane contains specific lipopolysaccharide structures.

ValWood commented 5 years ago

I'm not sure what the problem is. All I know is that there is a taxon restriction somewhere that prevents us from using the term? But I can't see what the taxon restriction is.

ValWood commented 5 years ago

I just rechecked and the term is still unavailable to us

ukemi commented 5 years ago

I see the taxon restriction, but do yeast have an outer CELL membrane and is it part_of a 'cell envelope'? Is this really the term you want to use?

ukemi commented 5 years ago

Don't they just have a plasma membrane and a cell wall?

ValWood commented 5 years ago

Oh I see what you mean, blind spot. It's the wrong term. @Antonialock

ukemi commented 5 years ago

cell envelope: An envelope that surrounds a bacterial cell and includes the cytoplasmic membrane and everything external, encompassing the periplasmic space, cell wall, and outer membrane if present.

mah11 commented 5 years ago

I think the taxon restriction for 'iron ion import across cell outer membrane' is correct - from what I recall, the 'cell outer membrane' business really is meant to apply to Bacteria (probably only Gram-negative bacteria at that). Other species don't have double cell membranes.

I wonder if the actual problem is this link (from #16776):

'high-affinity ferric iron transmembrane transporter activity' SubClassOf 'part of' some 'iron ion import across cell outer membrane'

because PMID:16522632, which is one of the papers cited in the GO:0033573 def, leads off with "The high affinity iron uptake complex in the yeast plasma membrane (PM) consists of the ferroxidase, Fet3p, and the ferric iron permease, Ftr1p." in the abstract, implying that some instances of 'high-affinity ferric iron transmembrane transporter activity' execution can be part of transport across yeast cell membranes.

mah11 commented 5 years ago

... it would be good to have @Antonialock confirm, though, because she's been working on iron transport in pombe and I haven't ;)

ValWood commented 5 years ago

Actually the term I can't approve is this one GO:0033573 high-affinity iron permease complex

mah11 commented 5 years ago

yeah, that's all part of the chain from https://github.com/geneontology/go-ontology/issues/16776#issuecomment-449491917 ... and it's the GO:0015092 part_of GO:0098706 link that looks most suspect to me

ValWood commented 5 years ago

See the comment from @balhoff in the previous ticket:

"Sorry for the slow reply! This one is due to an actual taxon constraint:

'high-affinity iron permease complex' SubClassOf 'capable of' some 'high-affinity ferric iron transmembrane transporter activity' 'high-affinity ferric iron transmembrane transporter activity' SubClassOf 'part of' some 'iron ion import across cell outer membrane' 'iron ion import across cell outer membrane' SubClassOf 'only in taxon' some Bacteria"

ukemi commented 5 years ago

I think @mah11 is correct.

Based on the def:

'high-affinity ferric iron transmembrane transporter activity' SubClassOf 'part of' some 'iron ion import across cell outer membrane'

should be: 'high-affinity ferric iron transmembrane transporter activity' SubClassOf 'part of' some 'iron ion transmembrane transport'

mah11 commented 5 years ago

@ukemi - yes, that sounds good. phew!

Antonialock commented 5 years ago

yep sounds good

ukemi commented 5 years ago

OK. I will fix this. I can actually do it with some shuffling of terms further up the graph that don't seem to have necessary and sufficient definitions. Thanks Everyone.