geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
223 stars 40 forks source link

Add primary input-output relations to manual pathways #16943

Closed ukemi closed 5 years ago

ukemi commented 5 years ago

Now that the has_primary_input and has_primary_output dust has settled, we need to go back and look at the pathways that we have manually created to change the metabolites appropriately. Another thing on our list next week @deustp01.

deustp01 commented 5 years ago

Yes. Do we have a NYC action item list or ticket? @ukemi

ukemi commented 5 years ago

You wish has come true. @vanaukenk, let's keep track of the things we do next Thursday and Friday in this project.

@huaiyumi @goodb @thomaspd @cmungall

ukemi commented 5 years ago

Many of these will probably be solved with the GCI updates, but we should check: #16953, #16951, #16950, #16949

ukemi commented 5 years ago

So here are some things to ponder:

NADH oxidation and NADPH oxidation/regeneration--- Are they NAD(P)H/NAD(P) metabolism? I think we don't want them to be.

@deustp01 I just did glycolysis, do you remember any other pathways we did that din't have biosynthesis/catabolism in their names?

deustp01 commented 5 years ago

Preventing unwanted reasoner inferences. We want to say that glycolysis is the conversion of glucose to pyruvate accompanied by the generation of NADH from NAD+ and of ATP from ADP. But then we need advice from someone good at writing weasely fine print on how to phrase this so the reasoner is not allowed to view glycolysis as an aspect of, or a variant of ATP and NADH metabolism.

Maybe we could go at it from the other end, and assert that "nucleotide metabolism" comprises reactions that convert non-nucleotide compounds into nucleotides and vice versa, as well as reactions that convert one nucleoptide into another (e.g., IMP to AMP) and non-nucleotide compounds and is separate from, maybe a sibling of, "nucleotide interconversion", reactions that alter the 5'-phosphorylation state of a nucleotide.

Then we wouldn't need to put limits on the reasoner - it would find nucleotide interconversion when it looks at glycolysis but that's OK.

I think this could work for NAD(P) as well - "NAD(P) metabolism" comprises reactions that convert other chemicals into NAD(P) and vice versa, while "NAD(P) - NAD(P)H interconversion or oxidoreduction" comprises reactions that change the redox state of NAD(P).

Pathway names that lack the words biosynthesis / catabolism. Among the ones we've thought about, the fermentations? More generally, TCA cycle, urea cycle, pentose phosphate pathway. There may be a pattern here: processes that are cyclical or that are networks don't necessarily progress from a single starting point to a single goal, while biosynthesis and catabolism do generally have this linear progressive feature. And the loops and networks do have metabolism grouping terms as parents, so their connection to linear metabolism is preserved. The fermentations are linear, but we could fix that by renaming "fermentation of pyruvate to X" to "fermentative catabolism of pyruvate to X".

Effects of all of this on slims are another issue.

ukemi commented 5 years ago

I think we can fulfill your wish. I will show you how on Thursday. I did a test with my favorite pathway.

ukemi commented 5 years ago

I did the fermentations and the pentose-phosphate shunt this afternoon. I did molybdenum cofactor biosynthesis. I think the TCA cycle is ok, but we should look together.

You're spot on in your second paragraph too!

ukemi commented 5 years ago

Added by hand in NYC.

ukemi commented 5 years ago

Note that the final decision was to include gycolysis as a metabolic process for the 'currency chemicals'. This is very easy to change if we change our minds.