geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

GO:0051090 regulation of DNA-binding transcription factor activity query #17064

Open ValWood opened 5 years ago

ValWood commented 5 years ago

I'm trying to figure how we would use

GO:0051090 regulation of DNA-binding transcription factor activity

This is a process term. If something is regulating a DNA binding transcription factor isn't it signalling? Of if you regulate the activity of a DNA-binding trancription factor directly this would be a molecular function term?

bmeldal commented 5 years ago

16 complexes are annotated with children of this term. They have no MF annotations. In the case of the one I checked (https://www.ebi.ac.uk/complexportal/complex/CPX-56) the evidence comes from an experiment where one of the complex components is mutated which causes an increase in transcription activity (by luciferase assay) (https://www.ncbi.nlm.nih.gov/pmc/articles/PMC3852661/, F6d, e) --> the complex is annotated with a neg reg child term.

pgaudet commented 5 years ago

Looks like these are readouts of signaling pathways. I would tend to obsolete and suggest reannotation to the pathway or regulation of the pathway.

@vanaukenk What do you think ?

RLovering commented 5 years ago

How will histone/DNA modifying TF cofactors be annotated? To regulation of DNA-binding transcription factor activity or would this be to regulation of DNA-binding, or regulation of transcription?

pgaudet commented 5 years ago

I would prefer it if we had 'regulator activity' for all direct regulations of protein activities, so the cofactors would be annotate to 'cofactor activity' or even 'transcription factor regulator activity', and to 'regulation of transcription'.

What do you think ?

Pascale

bmeldal commented 5 years ago

"regulator activity" would be great. I guess we'll have quite a few cases where that "X regulator activity" isn't in the ontology yet.

ValWood commented 5 years ago

How will histone/DNA modifying TF cofactors be annotated?

As far as I'm aware these are all "recruitment" https://github.com/pombase/curation/issues/2117 I would really like a "chromatin adaptor" to describe this activity (I was still thinking about it, but I think it solves a lot of other issues to where historically "localization" BP has been used.

pgaudet commented 5 years ago

We can certainly create 'chromatin adaptor' as a child of 'molecular adaptor activity'.

ValWood commented 4 years ago

So wiill "positive regulation of transcription factor activity" be obsoleted as part of the transcription overhaul. Most of the annotations are just upstream signalling....kinases etc

ValWood commented 4 years ago

the recruitment" part of this ticket is discussed here: https://github.com/geneontology/go-ontology/issues/17155

ValWood commented 4 years ago

Can we get "chromatin adaptor activity" for this?

I need it for tonnes of papers, including the one I am checking now: Conserved roles of chromatin remodellers in cohesin loading onto chromatin. PMID: 32277274

Screen Shot 2020-05-06 at 13 41 18

RSC complex is a chromatin remodeller removing nucleosomes for txn and other DNA metabolism" One subunit also acts as a chromatin adaptor for the Scc2/Scc4 cohesin loader complex

pgaudet commented 4 years ago

Hi @ValWood Can you provide a definition for NTR chromatin adaptor activity ? What is it bridging exactly ?

For eg the definition of 'protein-membrane adaptir activity' is

The binding activity of a molecule that brings together a protein or a protein complex with a membrane, or bringing together two membranes, either via membrane lipid binding or by interacting with a membrane protein, to establish or maintain the localization of the protein, protein complex or organelle.

Thanks, Pascale

ValWood commented 4 years ago

The binding activity of a molecule that brings together a protein or a protein complex with a nucleosome, to establish or maintain the chromatin localization of the protein, protein complex. synonym exact chromatin receptor related chromatin recruitment

this should work for everything

pgaudet commented 4 years ago

+[Term] +id: GO:0140463 +name: protein-chromatin adaptor activity +namespace: molecular_function +def: "The binding activity of a molecule that brings together a protein or a protein complex with a nucleosome, to establish or maintain the chromatin localization of the protein, protein complex." [PMID:32277274] +synonym: "chromatin adaptor activity" EXACT [] +synonym: "chromatin receptor" EXACT [] +is_a: GO:0030674 ! protein-macromolecule adaptor activity +property_value: term_tracker_item https://github.com/geneontology/go-ontology/issues/17064 xsd:anyURI +created_by: pg +creation_date: 2020-05-08T12:31:39Z

pgaudet commented 4 years ago

@ValWood I did not add the synonym 'chromatin recruitment', since this sounds like a process - I think that adds confusion. And related 'chromatin recruiter' sounded odd.

Thanks, Pascale

ValWood commented 4 years ago

I still think we should add "chromatin recruitment" related, because this activity is usually described as "recruitment" in publications. People will search in it. It does sound like a process which is why it's related.

RIght I'm done for the day!

ValWood commented 4 years ago

Can the primary term name be "chromatin adaptor" because that is the term the community would use (protein-chromatin adaptor doesn't come up in searches but could be an exact synonym)

ValWood commented 4 years ago

snall typo f the protein, protein complex - > or protein complex

pgaudet commented 4 years ago

Fixed typo and term label.

ValWood commented 4 years ago

Now that the MF term chromatin adaptor is created the outstanding question on this ticket is

How does BP regulation of DNA-binding transcription factor activity GO:0006355 regulation of transcription, DNA-templated

pgaudet commented 4 years ago

GO:0051090 regulation of DNA-binding transcription factor activity is_a GO:0006355 regulation of transcription, DNA-templated

Does that answer the question ?

ValWood commented 4 years ago

No, I would understand if it was an MF and part of the process, but this is a process. I still don't understand how the term would be used (in preference to a descendant of GO:0140110
transcription regulator activity), unless it is a "signalling pathway" in which case it is still a bit strange...