geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

More updates for mitochondrial transcription factor activity #19891

Closed pgaudet closed 4 years ago

pgaudet commented 4 years ago

Hello,

Working on the annotations to TFAM and the family PTHR48112, the function of the mt transcription activator is a mix of a dbTF and a GTF: the binding to the promoter is not sequence-specific, but rather binds a secondary structure (AT-rich region). Moreover, PTHR48112 contains HMG proteins, that have the same function of bending DNA and binding to bent DNA to (generally) make it more accessible to the transcriptional machinery.

To represent this more correctly, we have made the following changes:

Thanks, Pascale

pgaudet commented 4 years ago

@ValWood @srengel @tberardini Are these changes OK for plant and fungal mt transcription ? Specifically - we got rid of the 'sequence-specific' aspect, because that's not true in animals (ie for the only known TF, TFAM (Q00059). This makes it more general, the question is, do you want a term that captures the sequence-specific aspect of the function ?

Thanks, Pascale

pgaudet commented 4 years ago

@colinlog to follow

pgaudet commented 4 years ago

Actually for cerevisiae MTF1 this looks like the new definition - see Uniprot description: "Mitochondrial transcription factor that confers selective promoter recognition on the core subunit of the yeast mitochondrial RNA polymerase. Interacts with DNA in a non-specific manner."

pgaudet commented 4 years ago

Looking at the other animal mt transcription factors - TFB1M and TFB2M, which act without directly binding the DNA (ie more like co-factors), we will widen the definition to say "Interacting directly or indirectly with the mitochondrial promoter DNA to modulate transcription by the mitochondrial RNA polymerase".

This way we annotate more than 1 gene to the function.

ValWood commented 4 years ago

Re: changed the definition from "Interacting selectively and non-covalently with a specific double-stranded mitochondrial DNA sequence in order to modulate transcription by mitochondrial RNA polymerase."

what is the ID for this term? It isn't completely clear to me from the initial comment what is happening.

tberardini commented 4 years ago

@pgaudet I'm trying to get a handle on this issue. I think you mean that you are revisiting the annotation of a Panther family that has members from many different taxa, plants and fungi included, where the experimental annotation is to the animal members. Following from that, you are trying to figure out which specific GO term to apply to the unannotated members by IBA. It looks like the 'original' annotated animal GO term may not be appropriate for a reason that's not so clear to me. It also sounds like you want to edit the definitions of some of the GO terms in the branch of the ontology that you are considering.

Is that a correct general assessment?

pgaudet commented 4 years ago

Hi @tberardini

Sorry I wasn't very clear: In animals, there are 3 factors that participate in the activation of transcription (ie recruit and activate the mt RNA polymerase): TFAM, TFB1M and TF21M. According to @colinlog, their function are a mix of dbTFs, GTF and coTFs. TFAM binds DNA directly but not the other two.

So what we have done is (as stated in the original comment) is:

  1. moved the term from GO:0003700 DNA binding transcription factor activity, which is defined as a sequence-specific activity) to GO:0140110 transcription regulator activity
  2. changed the definition from "Interacting selectively and non-covalently with a specific double-stranded mitochondrial DNA sequence in order to modulate transcription by mitochondrial RNA polymerase." to "Interacting with the mitochondrial promoter DNA to modulate transcription by the mitochondrial RNA polymerase."

The question was, is this inconsistent with what happens in plans ? Since we made the term more general, we didn't think this would cause problems, but the question was, if you would like one (or more) more precise term(s) please do let us know. @colinlog said that mitochondria in fungi and animals and plants are more complicated than those of animals, so if more refined function are needed for plant mt transcription factors, please let us know (and point us to some papers if possible).

Thanks, Pascale

ValWood commented 4 years ago

I'm still confused what you have moved? Have you moved a term or an annotation?

and which term did you change the definition of? none of the terms mentioned in one mention "double-stranded mitochondrial DNA"

pgaudet commented 4 years ago

I'm still confused what you have moved? Have you moved a term or an annotation?

The term, GO:0034246. The definition is (was) "Interacting selectively and non-covalently with a specific double-stranded mitochondrial DNA sequence in order to modulate transcription by mitochondrial RNA polymerase. ".

ValWood commented 4 years ago

Ah OK. Pombase has not used this term. SGD has (MTF1).

I annotated MTF1 as GO:0016433 | rRNA (adenine) methyltransferase activity via InterPro https://www.pombase.org/gene/SPAC1002.08c

There is no evidence that it binds to DNA as far as I can see.

tberardini commented 4 years ago

We will request more specific terms should we need them for annotating A. thaliana. As far as I can tell, there are no current annotations that would be affected.

I see that you've moved the term already so the parentage has been adjusted. You will likely remove 'sequence-specific' from the term name when you edit the definition, correct?

http://amigo.geneontology.org/amigo/term/GO:0034246

pgaudet commented 4 years ago

You will likely remove 'sequence-specific' from the term name when you edit the definition, correct?

Yes ! And remove 'DNA binding' from the term label, since this term is meant to also cover TFB1M and TF21M, that do not bind DNA.

Thanks for the feedback. I'll make these change for this ticket, please open new tickets for any new terms.

Thanks, Pascale