Closed ValWood closed 3 years ago
I don't even think this was probably the original intent of the term...
tagging @cmungall and @pgaudet because the only ticket it is mentioned in is https://github.com/geneontology/go-ontology/issues/12231
This one has been on my hit-list for a few years, normally we just filter these ...
sensibly "ergosterol biosynthetic process" isn't an oxidation-reduction process, which highlights that it is a bit of a bonkers term and only refers to the MF
Happy for it to be obsoleted
I assume all the direct experimental annotations are actually propagated from MF (recall we used to use IC here but some time ago switched to retaining the original ref + evidence, which makes provenance harder; we don't need to revisit this discuss here however)
There are some direct annotation. I tried to look but would need to
(direct class) oxidation-reduction process GO:0055114 evidence_subset_closure_label: experimental evidence
and substract GO:0016491 oxidoreductase activity and see what is left.
The term oxidation-reduction process GO:0055114 has children which do represent meaningful processes. like GO:0022900 electron transport chain
but now I see thre are lots of children "substrate(x) oxidation" so it's not so simple to sort out.
Most if these annotation are not required. I only looked at one "formate oxidation", has 10 annotations for e.g. https://www.uniprot.org/uniprot/P32176 The process here is "respiration" (aerobic according to the UniProt description and anaerobic according to GO annotation).
This is relatively easy to do - most terms have other parents, except for
However that makes the parent node 'metabolic process' a bit more untidy (for a few terms, that was the only other parent).
Specific questions:
Should they all be under that term ?
Thanks, Pascale
'thioredoxin reduction' doesn't this one represent MF's too?
Specific questions:
1. 'NAD metabolic process' 'NADP metabolic process' 'NADH metabolic process' are children of 'metabolic process', while NADPH regeneration is a child of 'generation of precursor metabolites and energy'
Should they all be under that term ?
The distinction, if I remember right, is between processes that mediate the synthesis of these entities from and the degradation of these entities to other molecules (metabolism / biosynthesis / catabolism) and processes that mediate the interconversion of the reduced and oxidized forms of each. The interconversions, I think we agreed, are like the generation of ADP from ATP and vice versa, and are distinct from biosynthetic / catabolic metabolism. @ukemi @hdrabkin
Yes that was my understanding, so that not every rxn using NAD(P) gets tagged as NAD(P) metabolism.
From: deustp01 notifications@github.com Reply-To: geneontology/go-ontology reply@reply.github.com Date: Wednesday, November 18, 2020 at 11:45 AM To: geneontology/go-ontology go-ontology@noreply.github.com Cc: me Harold.Drabkin@jax.org, Mention mention@noreply.github.com Subject: [EXTERNAL]Re: [geneontology/go-ontology] oxidation-reduction process (#20250)
Specific questions:
'NAD metabolic process'
'NADP metabolic process'
'NADH metabolic process'
are children of 'metabolic process', while NADPH regeneration is a child of 'generation of precursor metabolites and energy'
Should they all be under that term ?
The distinction, if I remember right, is between processes that mediate the synthesis of these entities from and the degradation of these entities to other molecules (metabolism / biosynthesis / catabolism) and processes that mediate the interconversion of the reduced and oxidized forms of each. The interconversions, I think we agreed, are like the generation of ADP from ATP and vice versa, and are distinct from biosynthetic / catabolic metabolism. @ukemihttps://github.com/ukemi @hdrabkinhttps://github.com/hdrabkin
The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.
Dear all,
The proposal has been made to obsolete
The reason for obsoletion is that those terms represent molecular functions. There are no mappings; these terms are not present in any subsets.
We are opening a comment period for this proposed obsoletion. We’d like to proceed and obsolete this term on December 14th, 2020. Unless objections are received by December 14th, 2020, we will assume that you agree to this change. You can comment on the ticket: https://github.com/geneontology/go-ontology/issues/20250
Thanks, Pascale
@tberardini FYI - you can remove the annotations. The MF are already annotated.
Thanks, Pascale
@pgaudet You mean the annotations to 'thioredoxin reduction', right?
--Ok. They are gone.
@tberardini yes that's what I mean, thanks for reading my mind, saves some typing ;)
@pgaudet :) I was wondering if you meant the ones to 'oxidation-reduction process' but you haven't sent out an obsoletion notice for that yet.
oxidation-reduction process is used in the logical definition of
GO:0006150 hypoxanthine oxidation: 3 EXP annotations to xanthine dehydrogenase LD is 'catabolic process' and ('has part' some 'oxidation-reduction process') and ('has primary input' some hypoxanthine)
Similar for GO:0006151 xanthine oxidation - also has 3 EXP annotations to xanthine dehydrogenase
tyrosine biosynthetic process, by oxidation of phenylalanine also uses 'has part' some 'oxidation-reduction process' in the LD: 'biosynthetic process' and ('has part' some 'obsolete oxidation-reduction process') and ('has input' some phenylalanine) and ('has primary output' some tyrosine)
Thanks, Pascale
can we get rid of this meaningless term?
we are picking up quite a few PANTHER mappings to this term (I block all others). This is a bit of a useless grouping term- all that it means is that a gene product is an oxidoreductase. So now it looks like. some of our 'oxido eductases' of unknown physiological role are a known process, although they aren't. And even for the known ones, this term doesn't add anything - because it is really a MF in BP it's an orthogonal axis of classification:
it really isn't useful since every single one of the 35 million oxidoreductase in GOA is annotated to it.