geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

parts vs is_a parents #20501

Closed vanaukenk closed 3 years ago

vanaukenk commented 3 years ago

This is a follow-up to discussions we had on the 2020-11-30 ontology editors call.

Molecular functions can have different 'parts' or sub-functions, but it seems that sometimes these parts are is_a parents in the ontology and sometimes not.

For MFs like NTP-dependent molecular motors or NTP-dependent helicases (specifically I'm thinking of DEAD-box helicases), the gene products do enable an NTPase activity but NTP binding and protein or nucleic acid binding are critical parts of the overall function.

image

From: https://pubmed.ncbi.nlm.nih.gov/19748356/

In this example of a DEAD-box helicase, could the ATP binding and dsRNA binding also legitimately be 'is a' parents for the RNA helicase MF?

A possible GO-CAM representation of the DEAD-box helicase activity:

http://noctua.geneontology.org/editor/graph/gomodel:5fb9cc0600000424?model_id=gomodel:5fb9cc0600000424

pgaudet commented 3 years ago

I think (but I am not sure) that we were proposing to have all binding activities as 'has_part' of a more descriptive function; weren't we ?

ValWood commented 3 years ago

My understanding (mainly from reading in between the lines, but this is what seems to be a consensus)

  1. We aren't modelling 'conformations change' which is important for the activity but represents mechanistic detail below the resolution of GO MF
  2. So, in the above example the activity would be a helicase?. This MF would have part ATP binding

so isn't this just helicase Catalysis of the reaction: ATP + H2O = ADP + phosphate, to drive the unwinding of a DNA or RNA helix.

  1. I also thought the plan was for binding to be has_part of more descriptive functions.

When I was reviewing the tracker last week I found a ticket where @thomaspd confirmed this. I will see if I can locate it. and I found another ticket where I also asked the question.

pgaudet commented 3 years ago

@vanaukenk Can we ~you~ say this is resolved with the decision to use 'is a' for ATPases'?

pgaudet commented 3 years ago

@thomaspd your input would be useful

pgaudet commented 3 years ago

Discussion on ontology jamboree

pgaudet commented 3 years ago

May be solved with #20876

hattrill commented 3 years ago

tagging @sjm41

pgaudet commented 3 years ago

Hi @vanaukenk

Now that we created the distinction between ATP hydrolysis activity and ATPase activity, can this close?

20876

Thanks, Pascale

vanaukenk commented 3 years ago

@pgaudet - yes, I'll close it. Thx.