search

geneontology / go-ontology

Source ontology files for the Gene Ontology
http://geneontology.org/page/download-ontology
Creative Commons Attribution 4.0 International
220 stars 40 forks source link

cyclin-dependent protein kinase activating kinase activity (GO:0019912) #20884

Open ValWood opened 3 years ago

ValWood commented 3 years ago

this term will violate your new rule, re modifier and molecular function regulator,

butt I think we should get rid of this because it is kinase+ substrate, but covers a number of unrelated kinases.

other than transcription regulators, this was my only violation (1 annotation), there may be a few other terms. like this, I try to avoid them.

pgaudet commented 3 years ago

What would you replace it by ? Maybe just 'GO:0004672 protein kinase activity'? or maybe 'GO:0097472 cyclin-dependent protein kinase activity'?

If it's one of those two, it can probably merge.

ValWood commented 3 years ago

protein serine/threonine kinase activity has_input ( some cyclin dependent kinase)

This is what we would do now for inhibitory kinases like wee1 because we don't have

cyclin-dependent protein kinase "inhibiting" kinase activity its just a kinase....

pgaudet commented 3 years ago

So, obsolete GO:0019912 cyclin-dependent protein kinase activating kinase activity GO:0019914 cyclin-dependent protein kinase activating kinase regulator activity

with REPLACE_BY GO:0030295 protein kinase activator activity ?

ValWood commented 3 years ago

No, because these are kinases. Replace by GO-CAM or equivalent

protein kinase activity directly_activates substrate(a cyclin dependent kinse).

These don't fit your new 'regulator activity' definition