Open krchristie opened 3 years ago
Hi @kallia-p @zoependlington @paolaroncaglia
To make sure that GO does not obsolete any of the terms that EFO is using, we propose to make a subset for EFO terms so that we know to contact you about any proposed changes in advance.
Here are our existing subsets: subsetdef: goslim_agr "AGR slim" subsetdef: goslim_aspergillus "Aspergillus GO slim" subsetdef: goslim_candida "Candida GO slim" subsetdef: goslim_chembl "ChEMBL protein targets summary" subsetdef: goslim_drosophila "Drosophila GO slim" subsetdef: goslim_flybase_ribbon "FlyBase Drosophila GO ribbon slim" subsetdef: goslim_generic "Generic GO slim" subsetdef: goslim_metagenomics "Metagenomics GO slim" subsetdef: goslim_mouse "Mouse GO slim" subsetdef: goslim_pir "PIR GO slim" subsetdef: goslim_plant "Plant GO slim" subsetdef: goslim_pombe "Fission yeast GO slim" subsetdef: goslim_synapse "synapse GO slim" subsetdef: goslim_yeast "Yeast GO slim"
Looking at these and thinking about what you've said you are doing with GO terms, here's a proposed label for an EFO subset:
subsetdef: goslim_efo "Experimental Factor Ontology import"
If you're in agreement with this idea, I'll go ahead and make a subset in GO so we know what terms you're using. If you add additional terms in the future, let us know to add them by opening a new ticket.
Thanks,
-Karen
To confirm, we would create a new subset goslim_efo and label appropriate terms with it.
I thought we were going to obsolete the terms - then we could not make a slim? Let's discuss this...
@zoependlington @paolaroncaglia Are these GO terms still needed by EFO and would it be a problem if we obsolete those that don't have specific biological pathways? Thanks.
@dosumis @rays22 I believe you may be able to answer this better with regards to response to terms being created in OBA?
As far as if they're needed, I'd imagine anything under response to drug is probably being used currently by users, so if we can flag specific obsoletion candidates in a list we can send this out to our mailing list as a warning or prioritise creating replacements if they haven't already been created. The GO import in EFO is still static (I believe it's on the list of ontologies to make into a dynamic import), which means any changes in GO wouldn't automatically be reflected in EFO and would require manual editing. David and Ray, please correct me if I'm wrong here.
@rays22 has done lots of work on generating OBA terms that, AFAIK, replace all of the GO terms from this branch. The remaining difficulty is that we need a better strategy for properly integrating these with the terms EFO created in this branch.
I think we just need a status check on where this work has got to: make sure we have we have merged any open PRs in OBA and updated the OBA import to EFO to include all the terms. We should then be able to obsolete (or remove?) the GO terms in EFO (we have a mapping, so this could be automatic).
Would you be happy to do this before we've fully integrated with existing EFO terms? We've had an outstanding ticket on this for ages - I think stuck on some plan for semi-automating.
We have created OBA traits that are related to many of the GO terms in the table above. Please, note that these OBA terms are not equivalent replacements for the GO biological process terms. OBA terms are not process terms, but qualities. The OBA terms are targeted for GWAS and other trait use.
We do not yet have all the 75 GO terms from the table above in OBA. Currently we have these 38 OBA terms related to GO 'response to chemical entity' terms:
GO id | name | relationship | OBA id | OBA label |
---|---|---|---|---|
GO:0097337 | response to ziprasidone | skos:relatedMatch | OBA:2040002 | trait in response to ziprasidone |
GO:1903492 | response to acetylsalicylate | skos:relatedMatch | OBA:2040010 | trait in response to acetylsalicylic acid |
GO:0043278 | response to morphine | skos:relatedMatch | OBA:2040012 | trait in response to morphine |
GO:0036272 | response to gemcitabine | skos:relatedMatch | OBA:2040013 | trait in response to gemcitabine |
GO:0051384 | response to glucocorticoid | skos:relatedMatch | OBA:2040017 | trait in response to glucocorticoid |
GO:0014072 | response to isoquinoline alkaloid | skos:relatedMatch | OBA:2040018 | trait in response to isoquinoline alkaloid |
GO:1901563 | response to camptothecin | skos:relatedMatch | OBA:2040019 | trait in response to camptothecin |
GO:0072718 | response to cisplatin | skos:relatedMatch | OBA:2040020 | trait in response to cisplatin |
GO:0097331 | response to cytarabine | skos:relatedMatch | OBA:2040025 | trait in response to cytarabine |
GO:1902520 | response to doxorubicin | skos:relatedMatch | OBA:2040026 | trait in response to doxorubicin |
GO:1904014 | response to serotonin | skos:relatedMatch | OBA:2040027 | trait in response to serotonin |
GO:0097328 | response to carboplatin | skos:relatedMatch | OBA:2040032 | trait in response to carboplatin |
GO:1901556 | response to candesartan | skos:relatedMatch | OBA:2040038 | trait in response to candesartan |
GO:0097338 | response to clozapine | skos:relatedMatch | OBA:2040058 | trait in response to clozapine |
GO:1903493 | response to clopidogrel | skos:relatedMatch | OBA:2040062 | trait in response to clopidogrel |
GO:1902518 | response to cyclophosphamide | skos:relatedMatch | OBA:2040066 | trait in response to cyclophosphamide |
GO:0031427 | response to methotrexate | skos:relatedMatch | OBA:2040072 | trait in response to methotrexate |
GO:1901555 | obsolete response to paclitaxel | skos:relatedMatch | OBA:2040073 | trait in response to paclitaxel |
GO:0036275 | response to 5-fluorouracil | skos:relatedMatch | OBA:2040074 | trait in response to 5-fluorouracil |
GO:1902521 | response to etoposide | skos:relatedMatch | OBA:2040076 | trait in response to etoposide |
GO:0036274 | response to lapatinib | skos:relatedMatch | OBA:2040078 | trait in response to lapatinib |
GO:0010226 | response to lithium ion | skos:relatedMatch | OBA:2040080 | trait in response to lithium(1+) |
GO:1901557 | response to fenofibrate | skos:relatedMatch | OBA:2040081 | trait in response to fenofibrate |
GO:0031960 | response to corticosteroid | skos:relatedMatch | OBA:2040088 | trait in response to corticosteroid |
GO:1905119 | response to haloperidol | skos:relatedMatch | OBA:2040092 | trait in response to haloperidol |
GO:0097330 | response to 5-fluoro-2'-deoxyuridine | skos:relatedMatch | OBA:2040096 | trait in response to floxuridine |
GO:1901559 | response to ribavirin | skos:relatedMatch | OBA:2040100 | trait in response to ribavirin |
GO:0036288 | response to ximelagatran | skos:relatedMatch | OBA:2040106 | trait in response to ximelagatran |
GO:0036287 | response to iloperidone | skos:relatedMatch | OBA:2040107 | trait in response to iloperidone |
GO:1901558 | response to metformin | skos:relatedMatch | OBA:2040110 | trait in response to metformin |
GO:0036271 | response to methylphenidate | skos:relatedMatch | OBA:2040112 | trait in response to methylphenidate |
GO:1990054 | response to temozolomide | skos:relatedMatch | OBA:2040120 | trait in response to temozolomide |
GO:0097333 | response to olanzapine | skos:relatedMatch | OBA:2040125 | trait in response to olanzapine |
GO:0097334 | response to perphenazine | skos:relatedMatch | OBA:2040127 | trait in response to perphenazine |
GO:0097335 | response to quetiapine | skos:relatedMatch | OBA:2040134 | trait in response to quetiapine |
GO:0097336 | response to risperidone | skos:relatedMatch | OBA:2040135 | trait in response to risperidone |
GO:1903491 | response to simvastatin | skos:relatedMatch | OBA:2040136 | trait in response to simvastatin |
GO:1901905 | response to tamsulosin | skos:relatedMatch | OBA:2040138 | trait in response to tamsulosin |
@raymond91125 FYI, I'm no longer at EBI/EFO. Thanks.
Hi @krchristie @zoependlington @paolaroncaglia
I think, given the timing it would be best if we could both approach the 'response to' terms in a systematic way rather than as part of sporadic tickets about specific drugs. If you agree we could start discussing this in a new ticket. If needed I can join one of your future meetings to discuss and plan around the proposed work with regards to the alignment between GO, EFO and OBA 'response to' terms. Please let me know which of the two you prefer and if you think a meeting is warranted which forthcoming Monday we can allocate to this task.
I provide a bit of background and context to the preliminary work that I have done thus far. I am currently reviewing all of the terms that are in GO and have been imported in EFO (N=75 GO terms, see table below which comprises the EFO created 'response to' specific drug terms as well). I am also examining the OBA cross referenced terms with GO and the overlap between the three ontologies. With regards to EFO some of the imported GO terms are high level grouping terms with the main one being 'response to stimulus' of which 'response to chemical' is a Subclass Of. 'Response to drug' is a Subclass Of 'response to chemical' and I have made a note that you plan to merge this with 'response to xenobiotic'. Further down the GO hierarchy i.e. in the 'response to drug' branch there is some structure incorporated in GO that several EFO terms sit under for example the GO 'response to antipsychotic drug' and GO 'response to antineoplastic agent' have a number of children with either GO or EFO IDs for specific antipsychotic drugs and cancer therapy agents (with one of them being the GO 'response to paclitaxel' which you are planning to obsolete). Small changes like these will have less of an effect to our users but changes in higher level grouping terms will cause much disruption and I wonder why do you think EFO would be a better place for them than GO, and what is the hazard of keeping these kind of terms in GO.
I reviewed the tickets in trying to understand how GO views usage of the 'response to' terms in general. In my view an organism's response to an exogenous stimulus whether this is food intake, stress or a pharmacologic intervention constitutes a biological process; variations in our our genes interact with our environment. Many of the GWAS catalog studies associate variants with phenotypes that measure responses. Pharmacogenomics studies will specifically look for variants that modulate efficacy of a drug or adverse/toxic reactions. The GWAS catalog contains associations from gene x environment interactions studies as well. I think it also useful for researchers to know that (a variant affecting expression or function of) gene X which is associated with an adverse reaction to a drug Y (GO 'response to term') is linked to GO biological process Z.
Thanks!
Summary of discussion at GO Editors call on 9/27/21
Originally posted by @kallia-p in https://github.com/geneontology/go-ontology/issues/21998#issuecomment-926572432