cmungall
commented
2 years ago I think the range on both of these should be more specific, this will differentiate them
It is OK to have patterns whose members subsume one another, but it can be nice to have patterns at the same 'level'. Ideally chebi would have a small molecule class which would provide a nice balance
On Tue, Jan 11, 2022 at 9:38 PM pgaudet @.***> wrote:
Hello @balhoff https://github.com/balhoff @cmungall https://github.com/cmungall
https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/mf_binding.yaml and
have the same LD: equivalentTo: text: "'binding' and ('has input' some %s)"
- We should obsolete one of the two (I suggest we obsolete macromolecular_complex_binding.yaml)
- We need a check that prevents this situation
Thanks, Pascale
— Reply to this email directly, view it on GitHub https://github.com/geneontology/go-ontology/issues/22649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMOI5LZJ4NP54WWZCJ3TUVUHVFANCNFSM5LYCGGPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
Hello @balhoff @cmungall
https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/mf_binding.yaml and https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/macromolecular_complex_binding.yaml
have the same LD: equivalentTo: text: "'binding' and ('has input' some %s)"
Thanks, Pascale